Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get MLFLOW_TRACKING_UTI from env variables as default #2107

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

CarlosNacher
Copy link
Contributor

📝 Description

  • In AnomalibMLFlowLogger, tracking_uri was set to None, which was overriding the parameter in the underlying pytorch MLFlowLogger so you could never log in to a remote server. This fixes it.
  • 🛠️ Fixes # (NO EXISTING ISSUE YET)

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

In `AnomalibMLFlowLogger`, `tracking_uri` was set to None, which was overriding the parameter in the underlying pytorch `MLFloeLogger` so never could log into remote server. This fixes it.
@samet-akcay samet-akcay merged commit d094d4b into openvinotoolkit:main Jul 11, 2024
3 of 5 checks passed
@CarlosNacher CarlosNacher deleted the fix/mlflow_logger branch July 11, 2024 11:07
@samet-akcay samet-akcay added this to the v1.1.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants