Refactor and restructure anomalib.data

[samet-akcay]

📝 Description

• Split Torch datasets and Lightning Datamodules into datasets and datamodules
• Move dataclasses into data

✨ Changes

Select what type of change your PR is:

• 🐞 Bug fix (non-breaking change which fixes an issue)
• 🔨 Refactor (non-breaking change which refactors the code base)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

• 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
• 📚 I have made the necessary updates to the documentation (if applicable).
• 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

[djdameln]

As discussed, I'm in favor of this new structure. It seems the datasets submodule is missing though.

[samet-akcay]

As discussed, I'm in favor of this new structure. It seems the datasets submodule is missing though.

no idea what's wrong though. Tests locally pass 🙃

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Attention: Patch coverage is 91.29464% with 78 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/design-simplifications@1f9a7e0). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/anomalib/data/dataclasses/torch/image.py	84.00%	24 Missing ⚠️
src/anomalib/data/dataclasses/numpy/video.py	66.66%	9 Missing ⚠️
src/anomalib/data/datamodules/base/video.py	35.71%	9 Missing ⚠️
...rc/anomalib/data/datamodules/video/shanghaitech.py	80.85%	9 Missing ⚠️
src/anomalib/data/datamodules/video/ucsd_ped.py	83.87%	5 Missing ⚠️
src/anomalib/data/datasets/image/mvtec.py	87.80%	5 Missing ⚠️
src/anomalib/data/datasets/video/avenue.py	92.15%	4 Missing ⚠️
src/anomalib/data/dataclasses/torch/base.py	93.33%	2 Missing ⚠️
src/anomalib/data/dataclasses/torch/video.py	97.10%	2 Missing ⚠️
src/anomalib/data/datasets/image/btech.py	93.75%	2 Missing ⚠️
... and 7 more

Additional details and impacted files

@@                        Coverage Diff                        @@
##             feature/design-simplifications    #2302   +/-   ##
=================================================================
  Coverage                                  ?   80.32%           
=================================================================
  Files                                     ?      273           
  Lines                                     ?    11185           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?     8984           
  Misses                                    ?     2201           
  Partials                                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ashwinvaidya17]

So from what I understand, the intent of the PR is to split data into dataclasses and datamodules?

[samet-akcay]

So from what I understand, the intent of the PR is to split data into dataclasses and datamodules?

and also datasets. Overall, data will contain the dataclasses (item, batch etc.), datasets (torch) and datamodules (lightning)