Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure unit tests and fix ruff issues #2306

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Sep 18, 2024

πŸ“ Description

  • Fix ruff issues
  • Restructure the data unit tests to follow the same hierarchy as the anomalib.data

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@samet-akcay samet-akcay changed the base branch from main to feature/design-simplifications September 18, 2024 10:05
@samet-akcay samet-akcay changed the title Restructure unit tests Restructure unit tests and fix ruff issues Sep 18, 2024
@samet-akcay samet-akcay merged commit 8543e24 into openvinotoolkit:feature/design-simplifications Sep 18, 2024
5 checks passed
@samet-akcay samet-akcay deleted the restructure-unit-tests branch September 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants