🗑️ Remove numba

[ashwinvaidya17]

📝 Description

• Refactor 1

✨ Changes

Select what type of change your PR is:

• 🐞 Bug fix (non-breaking change which fixes an issue)
• 🔨 Refactor (non-breaking change which refactors the code base)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

• 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
• 📚 I have made the necessary updates to the documentation (if applicable).
• 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

[jpcbertoldo]

this function was like a demux for the two versions (python, numba), but without numba it becomes kind of redundant with the one that calls it (there are the validations tho)

[ashwinvaidya17]

Yeah I plan to simplify this with several PRs

[jpcbertoldo]

they are redundant with the PIMO class, right?
but if you call it without the class they aren't

[ashwinvaidya17]

These were just for myself. I am going to refactor the validation stuff so that we do it once at the outermost level.

[samet-akcay]

It would be good to have @jpcbertoldo as a reviewer in your pr series..

[jpcbertoldo]

i am checking them ;)

[jpcbertoldo]

why trapz instead of trapezoid?

[ashwinvaidya17]

imgaug does not support numpy 2.x, and np.trapezoid was introduced in numpy 2.x. Once imgaug is removed we can look into reverting this.

[samet-akcay]

Can we do something like this to avoid disabling ruff, and be more clear?

trapezoid = np.trapezoid if np.__version__ >= "2.0.0" else np.trapz
aucs: ndarray = trapezoid(per_image_tprs_bounded, x=shared_fpr_bounded_log, axis=1)

[ashwinvaidya17]

Ruff still throws an error. And, we won't need this once we switch everything to torch

[samet-akcay]

fair enough

[codecov]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature/pimo@29cb912). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/anomalib/metrics/per_image/pimo.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             feature/pimo    #2313   +/-   ##
===============================================
  Coverage                ?   80.75%           
===============================================
  Files                   ?      255           
  Lines                   ?    11949           
  Branches                ?        0           
===============================================
  Hits                    ?     9650           
  Misses                  ?     2299           
  Partials                ?        0           

Flag	Coverage Δ
	80.75% <95.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.