Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our CI OS from windows-2019 to windows-2022 #1172

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Oct 18, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim added the BUG Something isn't working label Oct 18, 2023
@vinnamkim vinnamkim added this to the 1.5.1 milestone Oct 18, 2023
@vinnamkim vinnamkim marked this pull request as ready for review October 18, 2023 08:59
@vinnamkim vinnamkim requested review from a team as code owners October 18, 2023 08:59
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team October 18, 2023 08:59
@vinnamkim vinnamkim added the CI Any changes in CI setting label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c02ed68) 79.96% compared to head (3814a9b) 79.96%.
Report is 1 commits behind head on releases/1.5.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1172   +/-   ##
===============================================
  Coverage           79.96%   79.96%           
===============================================
  Files                 267      267           
  Lines               29981    29981           
  Branches             5898     5898           
===============================================
  Hits                23975    23975           
  Misses               4649     4649           
  Partials             1357     1357           
Flag Coverage Δ
macos-11_Python-3.8 79.08% <ø> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 79.95% <ø> (ø)
windows-2019_Python-3.8 ?
windows-2022_Python-3.8 79.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim force-pushed the hotfix/windows-rmtree-error-in-cleaning-up-test-dir branch from 54d28c6 to 3814a9b Compare October 18, 2023 13:21
@vinnamkim vinnamkim requested a review from yunchu October 19, 2023 00:52
@vinnamkim vinnamkim changed the title Hotfix rmtree error in cleaning up test directory on Windows Update our CI OS from windows-2019 to windows-2022 Oct 19, 2023
@vinnamkim vinnamkim merged commit 8b5fef0 into openvinotoolkit:releases/1.5.0 Oct 19, 2023
9 of 12 checks passed
@vinnamkim vinnamkim deleted the hotfix/windows-rmtree-error-in-cleaning-up-test-dir branch October 19, 2023 01:18
yunchu pushed a commit to yunchu/datumaro that referenced this pull request Oct 23, 2023
…it#1172)

- Update our CI OS from `windows-2019` to `windows-2022`
- This is because our CI has problem only on `windows-2019` while
cleaning up test directory:
https://github.com/openvinotoolkit/datumaro/actions/runs/6549100531/job/17785292362
and
https://github.com/openvinotoolkit/datumaro/actions/runs/6557126906/job/17808184193?pr=1169

Signed-off-by: Kim, Vinnam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working CI Any changes in CI setting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants