Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imagenet when importing a dataset with non-directory files #1179

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners October 20, 2023 07:48
@wonjuleee wonjuleee requested review from sooahleex and removed request for a team October 20, 2023 07:48
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yunchu
Copy link
Contributor

yunchu commented Oct 20, 2023

#1178

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8f5ceb9) 79.96% compared to head (1eb656b) 79.96%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.5.0    #1179      +/-   ##
==================================================
- Coverage           79.96%   79.96%   -0.01%     
==================================================
  Files                 265      265              
  Lines               29702    29704       +2     
  Branches             5831     5831              
==================================================
+ Hits                23751    23752       +1     
- Misses               4618     4619       +1     
  Partials             1333     1333              
Flag Coverage Δ
macos-11_Python-3.8 79.08% <33.33%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 79.96% <33.33%> (-0.01%) ⬇️
windows-2022_Python-3.8 79.93% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/datumaro/plugins/data_formats/imagenet.py 83.67% <33.33%> (-0.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu added this to the 1.5.1 milestone Oct 23, 2023
@wonjuleee wonjuleee merged commit c2a31a8 into openvinotoolkit:releases/1.5.0 Oct 23, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants