Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImportError to catch GitPython import error #1186

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

vinnamkim
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim marked this pull request as ready for review October 25, 2023 14:08
@vinnamkim vinnamkim requested review from a team as code owners October 25, 2023 14:08
@vinnamkim vinnamkim requested review from jihyeonyi and removed request for a team October 25, 2023 14:08
@vinnamkim vinnamkim changed the title Add ImportError to catch GitPython import error [WIP] Add ImportError to catch GitPython import error Oct 25, 2023
@vinnamkim vinnamkim changed the title [WIP] Add ImportError to catch GitPython import error Add ImportError to catch GitPython import error Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (19fb861) 79.96% compared to head (97295e8) 79.96%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1186   +/-   ##
===============================================
  Coverage           79.96%   79.96%           
===============================================
  Files                 265      265           
  Lines               29705    29705           
  Branches             5831     5831           
===============================================
  Hits                23755    23755           
  Misses               4618     4618           
  Partials             1332     1332           
Flag Coverage Δ
macos-11_Python-3.8 79.09% <0.00%> (ø)
ubuntu-20.04_Python-3.8 79.96% <0.00%> (ø)
windows-2022_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/datumaro/util/os_util.py 66.66% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is it possible to add unit test for this?

@vinnamkim vinnamkim merged commit 07f2e78 into openvinotoolkit:releases/1.5.0 Oct 26, 2023
7 of 11 checks passed
@vinnamkim vinnamkim deleted the hotfix/rmtree branch October 26, 2023 01:09
@vinnamkim
Copy link
Contributor Author

LGTM, but is it possible to add unit test for this?

Used the administrator bypass option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants