Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] restore test for splitting video #1188

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Nov 6, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners November 6, 2023 13:15
@wonjuleee wonjuleee requested review from vinnamkim and removed request for a team November 6, 2023 13:15
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3055abb) 79.96% compared to head (9ac8cac) 79.97%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1188   +/-   ##
===============================================
  Coverage           79.96%   79.97%           
===============================================
  Files                 265      265           
  Lines               29705    29705           
  Branches             5831     5831           
===============================================
+ Hits                23755    23756    +1     
+ Misses               4618     4617    -1     
  Partials             1332     1332           
Flag Coverage Δ
macos-11_Python-3.8 79.09% <100.00%> (ø)
ubuntu-20.04_Python-3.8 79.96% <100.00%> (-0.01%) ⬇️
windows-2022_Python-3.8 79.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/datumaro/components/media.py 79.67% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit 01545bf into openvinotoolkit:releases/1.5.0 Nov 13, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants