Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cuboid2D annotation #1601

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

itrushkin
Copy link
Contributor

Summary

This introduces the new annotation type for 3D bounding box. This annotation is added to the Datumaro format.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Ilya Trushkin <[email protected]>
@itrushkin itrushkin requested review from a team as code owners September 10, 2024 09:01
@itrushkin itrushkin requested review from wonjuleee and removed request for a team September 10, 2024 09:01
Signed-off-by: Ilya Trushkin <[email protected]>
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your quick execution!
Could you add more tests?

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (ff5fd94) to head (21e5031).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/datumaro/components/visualizer.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1601   +/-   ##
========================================
  Coverage    81.06%   81.07%           
========================================
  Files          278      278           
  Lines        32517    32573   +56     
  Branches      6607     6617   +10     
========================================
+ Hits         26360    26408   +48     
- Misses        4701     4709    +8     
  Partials      1456     1456           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.06% <83.92%> (+<0.01%) ⬆️
windows-2022_Python-3.10 81.05% <83.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit 136694c into openvinotoolkit:develop Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants