Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeback/1.10.0rc1 #1658

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Oct 24, 2024

Summary

Mergeback from 1.10.0rc1 to develop

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

yunchu and others added 11 commits September 27, 2024 15:40
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->
- Support subset structure for KITTI 3d format
- Update media type from PointCloud to Image

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->
- Add unit test

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [X] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [X] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
…336px model (openvinotoolkit#1603)

- Update model for explorer openvino launcher with CLIP ViT-L/14@336px model
- Those models are quantized version with nncf
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

This fixes the bug in loading a keypoint dataset in datumaro format. 
The visibility information will be filled correctly by this fix.

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->
- Fixed the problem in
[action](https://github.com/openvinotoolkit/datumaro/actions/runs/11356378945/job/31587449268)
- This issue occurs occasionally

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
)

- Get `image` of tabular data for DmTorchDataset
- Update notebook
…toolkit#1648)

- `Clean` transform took long time due to tabular dataset usually have large dataset
- To reduce the time for transform, I made `TabularTransform` to do this process in parallel
- When I set `batch_size` as 100 and `num_workers` as 2, then the total process time reduces in half (about 300s -> 166s)
@yunchu yunchu requested review from a team as code owners October 24, 2024 06:51
@yunchu yunchu requested review from sooahleex and removed request for a team October 24, 2024 06:51
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 88.72180% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.19%. Comparing base (ff5fd94) to head (ebd6c04).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
...in/samples/clip_text_vit_l_14_336px_int8_interp.py 70.00% 5 Missing and 1 partial ⚠️
.../samples/clip_visual_vit_l_14_336px_int8_interp.py 91.89% 1 Missing and 2 partials ⚠️
src/datumaro/components/transformer.py 93.10% 1 Missing and 1 partial ⚠️
...c/datumaro/plugins/data_formats/kitti_3d/format.py 83.33% 1 Missing and 1 partial ⚠️
src/datumaro/components/annotation.py 0.00% 0 Missing and 1 partial ⚠️
src/datumaro/plugins/data_formats/kitti_3d/base.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1658      +/-   ##
===========================================
+ Coverage    81.06%   81.19%   +0.12%     
===========================================
  Files          278      283       +5     
  Lines        32517    33005     +488     
  Branches      6607     5309    -1298     
===========================================
+ Hits         26360    26798     +438     
- Misses        4701     4753      +52     
+ Partials      1456     1454       -2     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.17% <88.72%> (+0.12%) ⬆️
windows-2022_Python-3.10 81.17% <88.72%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu merged commit 2b4868d into openvinotoolkit:develop Oct 28, 2024
8 checks passed
@yunchu yunchu deleted the mergeback/1.10.0rc1 branch October 28, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants