Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Integrate C-IL for instance segmentation #19

Merged
merged 8 commits into from
Jun 29, 2022
Merged

Integrate C-IL for instance segmentation #19

merged 8 commits into from
Jun 29, 2022

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Jun 20, 2022

Summary

This PR includes :

@harimkang harimkang marked this pull request as ready for review June 27, 2022 00:01
model_classes = data_classes.copy()
model_classes = org_model_classes.copy()
else:
model_classes = data_classes.copy()
elif task_adapt_op == 'MERGE':
Copy link
Contributor Author

@harimkang harimkang Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goodsong81 @JihwanEom @jaegukhyun @chuneuny-emily @supersoob
Hi, I share this because I have a problem to think about together.

The current default value for task_adapt_op is 'MERGE'. It is done in most tasks, and it is not a problem in C-IL setting. The problem is that sometimes org_model_classes are imported when using 'coco pretrained weights' or other pretrained weights in a 'Supervised Learning setting'. (ex, 80 classes for coco)

To solve this problem, we can fix the code as above (155-157 lines) with 'REPACE' as default. This is the problem that appears in (the instance-segmentation ResNet pretrained weight) and detection (Yolox pretrained weight) so far.

If you have any concerns or ideas, please share them. Also, I wonder if this happens in other tasks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection for 'REPLACE' default. In SC/OTE the data_classes is the final target classes anyway.

Copy link
Collaborator

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harimkang harimkang merged commit c2e826f into develop Jun 29, 2022
@harimkang harimkang deleted the instance-seg branch June 29, 2022 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants