-
Notifications
You must be signed in to change notification settings - Fork 10
Integrate C-IL for instance segmentation #19
Conversation
model_classes = data_classes.copy() | ||
model_classes = org_model_classes.copy() | ||
else: | ||
model_classes = data_classes.copy() | ||
elif task_adapt_op == 'MERGE': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goodsong81 @JihwanEom @jaegukhyun @chuneuny-emily @supersoob
Hi, I share this because I have a problem to think about together.
The current default value for task_adapt_op is 'MERGE'. It is done in most tasks, and it is not a problem in C-IL setting. The problem is that sometimes org_model_classes are imported when using 'coco pretrained weights' or other pretrained weights in a 'Supervised Learning setting'. (ex, 80 classes for coco)
To solve this problem, we can fix the code as above (155-157 lines) with 'REPACE' as default. This is the problem that appears in (the instance-segmentation ResNet pretrained weight) and detection (Yolox pretrained weight) so far.
If you have any concerns or ideas, please share them. Also, I wonder if this happens in other tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection for 'REPLACE' default. In SC/OTE the data_classes is the final target classes anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
This PR includes :