Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANOMALY] Fix local anomaly segmentation performance bug #1219

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

djdameln
Copy link
Contributor

This PR fixes a bug in the anomaly segmentation performance computation. The full-image bounding boxes for the normal images of the ground truth dataset were included in the Dice score computation, but not the normal predictions of the prediction dataset. This resulted in underestimation of the performance.

Fixed by excluding the normal annotations from the computation.

@djdameln djdameln requested a review from a team as a code owner August 23, 2022 16:39
@github-actions github-actions bot added the API Any changes in OTX API label Aug 23, 2022
@djdameln
Copy link
Contributor Author

@atwinand

Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering this

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samet-akcay samet-akcay merged commit ad5e6ef into releases/v0.3.0-sc1.2 Aug 24, 2022
@samet-akcay samet-akcay deleted the da/fix-anomaly-local-score branch August 24, 2022 07:36
daniil-lyakhov pushed a commit to daniil-lyakhov/training_extensions that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants