Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCE] Update backbone lists #1835

Merged
merged 4 commits into from
Mar 2, 2023
Merged

[ENHANCE] Update backbone lists #1835

merged 4 commits into from
Mar 2, 2023

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Feb 27, 2023 •
edited
Loading

Summary

Updated the list of replaceable backbones for the latest OTX.

Updated Lib: version (number of backbone)
mmcls: 0.25.0 (18 -> 32)
mmdet: 2.28.1 (12 -> 19)
mmseg: 0.30.0 (20 -> 24)
torchvision: 0.14.1+cu116 (35 -> 56)

'+ Filtering in otx find

(otx) otx find --backbone mmdet
+-------+----------------------------------+-------------------+-------------------------------+
| Index |          Backbone Type           |   Required-Args   |            Options            |
+-------+----------------------------------+-------------------+-------------------------------+
|   1   |         mmdet.CSPDarknet         |        arch       |             P5, P6            |
|   2   |          mmdet.Darknet           |                   |                               |
|   3   |      mmdet.DetectoRS_ResNet      |       depth       |          50, 101, 152         |
|   4   |     mmdet.DetectoRS_ResNeXt      |       depth       |          50, 101, 152         |
|   5   |        mmdet.EfficientNet        |        arch       |                               |
|   6   |        mmdet.HourglassNet        |                   |                               |
|   7   |           mmdet.HRNet            |       extra       |                               |
|   8   |        mmdet.MobileNetV2         |                   |                               |
|   9   |  mmdet.PyramidVisionTransformer  |                   |                               |
|   10  | mmdet.PyramidVisionTransformerV2 |                   |                               |
|   11  |           mmdet.RegNet           |        arch       | regnetx_400mf, regnetx_800mf, |
|       |                                  |                   | regnetx_1.6gf, regnetx_3.2gf, |
|       |                                  |                   | regnetx_4.0gf, regnetx_6.4gf, |
|       |                                  |                   |  regnetx_8.0gf, regnetx_12gf  |
|   12  |          mmdet.Res2Net           |       depth       |          50, 101, 152         |
|   13  |          mmdet.ResNeSt           |       depth       |       50, 101, 152, 200       |
|   14  |           mmdet.ResNet           |       depth       |      18, 34, 50, 101, 152     |
|   15  |         mmdet.ResNetV1d          |       depth       |      18, 34, 50, 101, 152     |
|   16  |          mmdet.ResNeXt           |       depth       |          50, 101, 152         |
|   17  |           mmdet.SSDVGG           |     input_size    |            300, 512           |
|       |                                  |       depth       |           11, 16, 19          |
|   18  |      mmdet.SwinTransformer       |                   |                               |
|   19  |       mmdet.TridentResNet        |       depth       |      18, 34, 50, 101, 152     |
|       |                                  |     num_branch    |                               |
|       |                                  |  test_branch_idx  |                               |
|       |                                  | trident_dilations |                               |
+-------+----------------------------------+-------------------+-------------------------------+

(otx) otx find --backbone mmdet --task instance_segmentation
+-------+-------------------------+-------------------+-------------------------------+
| Index |      Backbone Type      |   Required-Args   |            Options            |
+-------+-------------------------+-------------------+-------------------------------+
|   1   |     mmdet.CSPDarknet    |        arch       |             P5, P6            |
|   2   |      mmdet.Darknet      |                   |                               |
|   3   |  mmdet.DetectoRS_ResNet |       depth       |          50, 101, 152         |
|   4   | mmdet.DetectoRS_ResNeXt |       depth       |          50, 101, 152         |
|   5   |    mmdet.HourglassNet   |                   |                               |
|   6   |       mmdet.HRNet       |       extra       |                               |
|   7   |    mmdet.MobileNetV2    |                   |                               |
|   8   |       mmdet.RegNet      |        arch       | regnetx_400mf, regnetx_800mf, |
|       |                         |                   | regnetx_1.6gf, regnetx_3.2gf, |
|       |                         |                   | regnetx_4.0gf, regnetx_6.4gf, |
|       |                         |                   |  regnetx_8.0gf, regnetx_12gf  |
|   9   |      mmdet.Res2Net      |       depth       |          50, 101, 152         |
|   10  |      mmdet.ResNeSt      |       depth       |       50, 101, 152, 200       |
|   11  |       mmdet.ResNet      |       depth       |      18, 34, 50, 101, 152     |
|   12  |     mmdet.ResNetV1d     |       depth       |      18, 34, 50, 101, 152     |
|   13  |      mmdet.ResNeXt      |       depth       |          50, 101, 152         |
|   14  |       mmdet.SSDVGG      |     input_size    |            300, 512           |
|       |                         |       depth       |           11, 16, 19          |
|   15  |   mmdet.TridentResNet   |       depth       |      18, 34, 50, 101, 152     |
|       |                         |     num_branch    |                               |
|       |                         |  test_branch_idx  |                               |
|       |                         | trident_dilations |                               |
+-------+-------------------------+-------------------+-------------------------------+

@harimkang harimkang requested a review from a team as a code owner February 27, 2023 02:53
@github-actions github-actions bot added the CLI Any changes in OTE CLI label Feb 27, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 80.47% // Head: 80.49% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (2b881d1) compared to base (a7245b6).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1835      +/-   ##
===========================================
+ Coverage    80.47%   80.49%   +0.02%     
===========================================
  Files          477      477              
  Lines        32902    32902              
===========================================
+ Hits         26477    26484       +7     
+ Misses        6425     6418       -7
Impacted Files Coverage Δ
otx/api/utils/shape_factory.py 95.38% <0.00%> (+1.53%) ⬆️
otx/algorithms/detection/tasks/inference.py 73.78% <0.00%> (+2.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eunwoosh
Copy link
Contributor

ToDo

The newly added backbone needs to be verified. I will update the list once more after verification.

Does it mean that this PR will include additional update?

@harimkang
Copy link
Contributor Author

It's not this PR, there will be a new PR later.

jaegukhyun
jaegukhyun previously approved these changes Feb 27, 2023
View reviewed changes
eunwoosh
eunwoosh previously approved these changes Feb 27, 2023
View reviewed changes
@harimkang harimkang dismissed stale reviews from eunwoosh and jaegukhyun via b17fd5e February 27, 2023 08:36
goodsong81
goodsong81 requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to rebase. The hanging issue was fixed (or avoided) from the 1.0 merge-back.

@harimkang
Copy link
Contributor Author

You may want to rebase. The hanging issue was fixed (or avoided) from the 1.0 merge-back.

Thank you for letting me know. It's corrected.

@harimkang harimkang enabled auto-merge (squash) March 2, 2023 11:47
@harimkang harimkang merged commit 6cba8c9 into develop Mar 2, 2023
@harimkang harimkang deleted the harimkan/backbone-list-update branch March 2, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@jaegukhyun jaegukhyun jaegukhyun left review comments

@eunwoosh eunwoosh eunwoosh left review comments

Assignees
No one assigned
Labels
CLI Any changes in OTE CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harimkang @codecov-commenter @eunwoosh @goodsong81 @sungmanc @jaegukhyun