Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Run integration test on each task's environment #1859

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Mar 7, 2023

Summary

This PR adds pre-merge tests with pip install .[each_task] to tox and applies them to github action for keeping it available to run each task with pip install .[each_task].

Add multiprocess package in requirement/base.txt

Currently merged PR uses multiprocess. But action task doesn't install it, so it makes an error for that (other tasks installed it). So I added it as requirement.

@github-actions github-actions bot added the BUILD label Mar 7, 2023
@eunwoosh eunwoosh marked this pull request as ready for review March 7, 2023 05:55
@eunwoosh eunwoosh requested a review from a team as a code owner March 7, 2023 05:55
@eunwoosh eunwoosh requested a review from yunchu March 7, 2023 05:56
sungmanc
sungmanc previously approved these changes Mar 7, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation, LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (dcf1ad0) 80.51% compared to head (99add93) 80.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1859      +/-   ##
===========================================
+ Coverage    80.51%   80.53%   +0.02%     
===========================================
  Files          477      481       +4     
  Lines        32839    32983     +144     
===========================================
+ Hits         26440    26564     +124     
- Misses        6399     6419      +20     
Impacted Files Coverage Δ
...orithms/detection/adapters/mmdet/data/pipelines.py 89.79% <0.00%> (-3.26%) ⬇️
otx/mpa/modules/hooks/recording_forward_hooks.py 91.96% <0.00%> (-2.26%) ⬇️
otx/api/utils/shape_factory.py 93.84% <0.00%> (-1.54%) ⬇️
otx/algorithms/common/utils/data.py 48.48% <0.00%> (-1.02%) ⬇️
otx/algorithms/detection/tasks/inference.py 72.65% <0.00%> (-0.75%) ⬇️
otx/api/entities/dataset_item.py 98.88% <0.00%> (-0.56%) ⬇️
otx/mpa/modules/hooks/eval_hook.py 100.00% <0.00%> (ø)
otx/algorithms/common/configs/training_base.py 100.00% <0.00%> (ø)
...thms/segmentation/adapters/mmseg/data/pipelines.py 100.00% <0.00%> (ø)
...ms/classification/adapters/mmcls/data/pipelines.py 100.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

goodsong81
goodsong81 previously approved these changes Mar 7, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Might need some refactoring, but I'll handle it later w/ other Python version variant. Thanks!

@eunwoosh eunwoosh dismissed stale reviews from goodsong81 and sungmanc via 99add93 March 7, 2023 07:13
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Mar 7, 2023
@jaegukhyun
Copy link
Contributor

Pre-Merge-Integration-Test Expected — Waiting for status to be reported
Should we remove pre-merge integration test?

@eunwoosh
Copy link
Contributor Author

eunwoosh commented Mar 7, 2023

Pre-Merge-Integration-Test Expected — Waiting for status to be reported Should we remove pre-merge integration test?

It's already removed in my PR. I don't know why it's stuck at that test :(

@eunwoosh
Copy link
Contributor Author

eunwoosh commented Mar 8, 2023

I understand what problem is. Current PR setting specifies Pre-Merge-Integration-Test as required for merging, but I removed that test. So it's stuck at that point. I think that setting should be changed after this PR is merged. Could you check that, @yunchu, @goodsong81 ?

@goodsong81 goodsong81 merged commit af3c3b1 into develop Mar 8, 2023
@goodsong81 goodsong81 deleted the es/indep_task_env_pre_merge branch March 8, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants