-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Run integration test on each task's environment #1859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation, LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1859 +/- ##
===========================================
+ Coverage 80.51% 80.53% +0.02%
===========================================
Files 477 481 +4
Lines 32839 32983 +144
===========================================
+ Hits 26440 26564 +124
- Misses 6399 6419 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Might need some refactoring, but I'll handle it later w/ other Python version variant. Thanks!
Pre-Merge-Integration-Test Expected — Waiting for status to be reported |
It's already removed in my PR. I don't know why it's stuck at that test :( |
I understand what problem is. Current PR setting specifies |
Summary
This PR adds pre-merge tests with
pip install .[each_task]
to tox and applies them to github action for keeping it available to run each task withpip install .[each_task]
.Add multiprocess package in requirement/base.txt
Currently merged PR uses
multiprocess
. But action task doesn't install it, so it makes an error for that (other tasks installed it). So I added it as requirement.