-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Dataset Adapter: Avoid duplicated annotation and permit empty image #1873
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1873 +/- ##
===========================================
- Coverage 80.54% 80.54% -0.01%
===========================================
Files 484 484
Lines 33005 33007 +2
===========================================
Hits 26585 26585
- Misses 6420 6422 +2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dataset w/o annotations need to be filtered out during training stage. I run detection on this branch but it isn't.
@eunwoosh , I added logic to avoid inputting the empty image to train dataset. And changed tests/assets. |
Co-authored-by: Eunwoo Shin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@supersoob , @jaegukhyun could you recheck this? |
This PR includes
len(shapes) >0
.DatasetItemEntity
. -->len(datumaro_item.annotations)==0
.DatasetItemEntity
. -->subset == Subset.UNLABELED
To test the empty_label case, I modified the test data that includes the empty_label image.
Implement unit-test to validate whether empty_label image is successfully included in
DatasetItemEntity
or not.Test results
Thanks for reporting this issue. @eunwoosh , @supersoob