-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add train-type parameter to otx train #1874
Conversation
6a8a893
to
ac734b7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1874 +/- ##
========================================
Coverage 80.54% 80.55%
========================================
Files 484 483 -1
Lines 33005 32968 -37
========================================
- Hits 26585 26557 -28
+ Misses 6420 6411 -9
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @harimkang Could you have a look?
I'm not sure why we should use Example for SemiSL:
Example for SelfSL:
|
I agree to some extent, but vlad seems to want to improve the inconvenience. However, there can be conflicts between the two methods(use train_type / use params), and it seems that this could cause problems somewhere. (maybe not..?) |
|
|
ac734b7
to
4b2ec68
Compare
After this PR is merged, we need to consider eliminating |
Currently, to enable SSL training we have to execute oxt build at the first step.
At the same time, otx train allows passing --unlabeled-data-roots, which causes a failure if otx build hasn't been executed before.
Therefore, CLI of otx train is contradictive and incomplete. This PR brings back missing ability to launch different training types right from otx train CLI.
This contradiction is caused by mixing two paradigms for launching a training: pre-configuration of a workspace and passing all the required arguments via CLI. The possible solutions are:
This PR follows the second option, but the first one deserves discussion as well.