-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and refactor the output of the OTX CLI #1946
Clean up and refactor the output of the OTX CLI #1946
Conversation
…_extensions into harimkan/output-align
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1946 +/- ##
===========================================
- Coverage 80.72% 80.69% -0.03%
===========================================
Files 482 482
Lines 33221 33244 +23
===========================================
+ Hits 26818 26827 +9
- Misses 6403 6417 +14
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, this is the pretty good improvement :)
BTW, for the deploy, eval, export, optimize, and train.py, will we support -o
argument?
In the documentation, there is no description for -o
argument. So, how about removing this argument?
- We have 3 scenarios as below, how about adding simple unit-tests for these scenarios?
- --output (no --workspace)
- --workspace (no --output)
- --workspace + --output
docs/source/guide/get_started/quick_start_guide/cli_commands.rst
Outdated
Show resolved
Hide resolved
IMHO, |
We decided to move the This is currently working as expected, so I'm going to leave the PR open for reviews, and I'd love to hear your thoughts on this PR. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked only code parts(it's really hard to look docs and test files...), and the code works look really good to me. Thank you for your effort
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Summary
Clean up OTX's unorganized output and policies, and various arguments related to output.
New args in CLI
--work-dir
->--workspace
: otx workspace path.--save-model-to
&--save-performance
->--output
: output directory path.New output
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.