Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dataset.with_empty_annotations() to keep original input structure #1964

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Remove dataset.with_empty_annotations() to keep original input structure #1964

merged 1 commit into from
Apr 3, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Apr 3, 2023 •
edited
Loading

Summary

  • Fix an Geti integration error due to changed data type.
    (Dataset -> DatasetEntity)

How to test

  • n/a

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81 goodsong81 requested a review from a team as a code owner April 3, 2023 11:06
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 3, 2023
@goodsong81 goodsong81 changed the title Remove dataset.with_empty_annotations() call to keep original input sturcture Remove dataset.with_empty_annotations() to keep original input structure Apr 3, 2023
sungmanc
sungmanc approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this error only occurs in classification?

@goodsong81
Copy link
Contributor Author

Does this error only occurs in classification?

There seems no other calls which alter output structure.
(val dataset creation seems OK)
image

@goodsong81 goodsong81 merged commit a734443 into openvinotoolkit:releases/1.1.2 Apr 3, 2023
@goodsong81 goodsong81 deleted the songkich/fix-empty-anno branch April 3, 2023 12:11
goodsong81 added a commit to goodsong81/training_extensions that referenced this pull request Apr 4, 2023
@goodsong81
Remove dataset.with_empty_annotations() to keep original input stru…
884018a 
…cture (openvinotoolkit#1964)

Remove dataset.with_empty_annotations() call to keep original input structure
goodsong81 added a commit that referenced this pull request Apr 5, 2023
@goodsong81 @negvet
Merge back bug fixes in release 1.1.2 (#1971)
6939daf 
* Fix exception -> warning for anomaly dump_feature option

* Remove `dataset.with_empty_annotations()` to keep original input structure (#1964)

* Fix OV batch inference (saliency map generation)  (#1965)

* Release 1.1.2 RC1

* Fix classification model download logic to resolve zip issue (#1967)

* Replace model download logic by pytorchcv to resolve zip issue

* Update change log

* Fix pre-commit

* Configure checkpoint before model

* Add pytorchcv to cls/seg requirement

* Hot fix for numpy attr for ResultMediaEntity

* Release 1.1.2

* Update exportable code demo commit

---------

Co-authored-by: Evgeny Tsykunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix HOTFIX RELEASE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodsong81 @sungmanc