Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onnx to the resulting ModelEntity in export() #1976

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Add onnx to the resulting ModelEntity in export() #1976

merged 2 commits into from
Apr 12, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Apr 5, 2023 •
edited
Loading

Summary

Onnx model is appended to the resulting ModelEntity on every export. Tests are modified accordingly.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov requested a review from a team as a code owner April 5, 2023 16:50
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Apr 5, 2023
@sovrasov sovrasov changed the title Vs/onnx export Add onnx to the resulting ModelEntity in export() Apr 5, 2023
@goodsong81 goodsong81 added this to the 1.2.0 milestone Apr 6, 2023
@sovrasov sovrasov force-pushed the vs/onnx_export branch 6 times, most recently from 1fe00ef to 1cc8bed Compare April 11, 2023 14:13
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 11, 2023
@sovrasov
Fix fp16 onnx export for detection
1cc8bed 
Add dumping onnx model to model entity

Fix action tests

Fix segmentaion tests
@sovrasov
Update changelog
3e2f1c5
@jaegukhyun jaegukhyun merged commit cacc35a into openvinotoolkit:develop Apr 12, 2023
jaegukhyun added a commit to jaegukhyun/training_extensions that referenced this pull request Apr 12, 2023
@jaegukhyun
Reflect changes from openvinotoolkit#1976
a9d15d9
jaegukhyun added a commit to jaegukhyun/training_extensions that referenced this pull request Apr 12, 2023
@jaegukhyun
Reflect changes from openvinotoolkit#1976
7385752
jaegukhyun added a commit to jaegukhyun/training_extensions that referenced this pull request Apr 12, 2023
@jaegukhyun
Reflect changes from openvinotoolkit#1976
b573d69
jaegukhyun added a commit that referenced this pull request Apr 12, 2023
@jaegukhyun
Split export function and _export_model function for detection task (#…
10fce79 
…1997)

* Split export function and _export_model function for detection task

* Add basic unit test for detection task

* Update change log

* Reflect changes from #1976

* Fix unit test failure
jaegukhyun added a commit that referenced this pull request Apr 12, 2023
@jaegukhyun
Refactor action tasks and remove unused modules (#1993)
159cfff 
* Refactor action tasks and remove unused modules

* Add openvino task unit test

* Add unit test for action tasks

* Update changelog

* Reflect changes from #1976

* Reflect Reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@harimkang harimkang harimkang approved these changes

@goodsong81 goodsong81 Awaiting requested review from goodsong81 goodsong81 is a code owner

@sungmanc sungmanc Awaiting requested review from sungmanc

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sovrasov @harimkang @jaegukhyun @goodsong81