Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation refactoring #1977

Merged
merged 11 commits into from
Apr 7, 2023

Conversation

JihwanEom
Copy link
Contributor

@JihwanEom JihwanEom commented Apr 5, 2023

Summary

Apply the changes in that PR (#1955, Detection task refactoring) to the segmentation.

Experiments

Dataset: kvasir-seg train/val 300 imgs subset, lite-hrnet-18-mod-2, seed=0, deterministic=True
# Before refactoring
Performance: 0.7979 mDice, 251sec.
# After refactoring
Performance: 0.8093 mDice, 246sec.
  • Unit-Test
    image

  • Integration Test (segmentation)
    image

  • E2E Test (segmentation): Same issue as detection -> will be explored together
    image
    -> Fixed by @jaegukhyun
    image

How to test

pytest -s -v tests/integration/cli/segmentation
pytest -s -v tests/e2e/cli/segmentation

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Apr 5, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 6, 2023
@JihwanEom JihwanEom marked this pull request as ready for review April 6, 2023 06:59
@JihwanEom JihwanEom requested a review from a team as a code owner April 6, 2023 06:59
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a good progress in a short time! I left a few comments.

Copy link
Contributor

@supersoob supersoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work. I commented some.

@JihwanEom JihwanEom requested a review from supersoob April 6, 2023 17:36
harimkang
harimkang previously approved these changes Apr 7, 2023
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, could you check them?

otx/algorithms/segmentation/adapters/mmseg/task.py Outdated Show resolved Hide resolved
otx/algorithms/segmentation/adapters/mmseg/task.py Outdated Show resolved Hide resolved
otx/algorithms/segmentation/adapters/mmseg/task.py Outdated Show resolved Hide resolved
otx/algorithms/segmentation/adapters/mmseg/task.py Outdated Show resolved Hide resolved
otx/algorithms/segmentation/adapters/mmseg/task.py Outdated Show resolved Hide resolved
otx/algorithms/segmentation/adapters/mmseg/configurer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort! LGTM

@JihwanEom JihwanEom enabled auto-merge (squash) April 7, 2023 04:42
Copy link
Contributor

@supersoob supersoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@JihwanEom JihwanEom merged commit 8742e70 into openvinotoolkit:develop Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants