Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add training loss dynamics exportation feature for multi-class classification task #1985

Merged
merged 16 commits into from
Apr 10, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 7, 2023

Summary

  • Ticket no. 103075
  • Add training loss dynamics exportation feature for multi-class classification task.
  • Documentation and example for this feature will be added soon.

How to test

I added tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests labels Apr 7, 2023
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim changed the title Vinnamki/feature/noisy label detection cls Add training loss dynamics exportation feature for multi-class classification task Apr 7, 2023
@vinnamkim vinnamkim marked this pull request as ready for review April 7, 2023 07:51
@vinnamkim vinnamkim requested a review from a team as a code owner April 7, 2023 07:51
Signed-off-by: Kim, Vinnam <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch coverage: 81.96% and project coverage change: +0.09 🎉

Comparison is base (0e045d2) 74.90% compared to head (4024877) 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1985      +/-   ##
===========================================
+ Coverage    74.90%   75.00%   +0.09%     
===========================================
  Files          460      462       +2     
  Lines        34585    34742     +157     
===========================================
+ Hits         25907    26057     +150     
- Misses        8678     8685       +7     
Flag Coverage Δ
py310 74.98% <81.96%> (+0.09%) ⬆️
py38 74.98% <81.96%> (+0.09%) ⬆️
py39 74.99% <81.96%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lassification/adapters/mmcls/utils/config_utils.py 50.00% <0.00%> (ø)
...x/algorithms/classification/adapters/mmcls/task.py 14.66% <33.33%> (+0.16%) ⬆️
...isy_label_detection/loss_dynamics_tracking_hook.py 51.16% <51.16%> (ø)
...sification/adapters/mmcls/models/losses/ib_loss.py 73.80% <75.00%> (+38.80%) ⬆️
otx/api/entities/dataset_item.py 97.48% <85.00%> (-1.41%) ⬇️
otx/core/data/noisy_label_detection/base.py 90.47% <90.47%> (ø)
...ication/adapters/mmcls/models/classifiers/mixin.py 96.72% <96.72%> (ø)
...sification/adapters/mmcls/datasets/otx_datasets.py 77.45% <100.00%> (+0.58%) ⬆️
...dapters/mmcls/models/classifiers/sam_classifier.py 82.92% <100.00%> (+0.97%) ⬆️
...ithms/classification/configs/base/configuration.py 100.00% <100.00%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cih9088
cih9088 previously approved these changes Apr 7, 2023
@goodsong81 goodsong81 added the FEATURE New feature & functionality label Apr 7, 2023
@goodsong81 goodsong81 added this to the 1.2.0 milestone Apr 7, 2023
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks OK to me, but I have some concern about Geti compatibility.
sc_sdk in Geti is heavily depending on otx.api (aka ote_sdk) so that we need to be careful when changing definitions in entities. Could you verify if it's all OK? You may get review from IAI team, too.

otx/api/entities/datasets.py Outdated Show resolved Hide resolved
otx/api/entities/datasets.py Show resolved Hide resolved
@goodsong81
Copy link
Contributor

There was some changes in CI settings. Could you rebase?

Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim
Copy link
Contributor Author

There was some changes in CI settings. Could you rebase?

Merged the latest develop

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goodsong81
Copy link
Contributor

@vinnamkim Please update the change log in the next PR for documentation. Thanks!

@goodsong81 goodsong81 merged commit 746e6eb into develop Apr 10, 2023
@goodsong81 goodsong81 deleted the vinnamki/feature/noisy-label-detection-cls branch April 10, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API FEATURE New feature & functionality TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants