Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: set gpu_ids properly #2071

Merged

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Apr 26, 2023

gpu_ids should be an iterateable variable which has single element in single GPU training case.
Current implementation doesn't if CUDA_VISIBLE_DEVICES has multiple integers.
This PR fixed the issue #2070

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added the FIX defect fix label Apr 26, 2023
@eunwoosh eunwoosh added this to the 1.2.0 milestone Apr 26, 2023
@eunwoosh eunwoosh requested a review from a team as a code owner April 26, 2023 03:56
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 26, 2023
@eunwoosh eunwoosh requested a review from sungmanc April 26, 2023 03:57
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch

@eunwoosh eunwoosh merged commit 845e880 into openvinotoolkit:releases/1.2.1 Apr 26, 2023
goodsong81 pushed a commit to goodsong81/training_extensions that referenced this pull request Apr 27, 2023
use fisrt GPU of cuda visible devices
goodsong81 added a commit that referenced this pull request May 3, 2023
* Upgrade mmdeploy==0.14.0 from official PyPI (#2047)

* Bug fix: value of validation variable is changed after auto decrease batch size (#2053)

* Integrate new ignored loss in semantic segmentation (#2065)

* Remove unused modules in semantic segmentation (#2068)

* Add doc for fast data loading (#2069)

* Bug fix: set gpu_ids properly (#2071)

* Bug fix: Progress goes 100% and back 0 % repeatedly during auto decrease bs in Geti (#2074)

* Fix tiling 0 stride issue in parameter adapter (#2078)

* Update instance-segmentation tutorial documentation (#2082)

* Optimize YOLOX data pipeline and add unit test for get_subset of Datu… (#2075)

* Tiling Spatial Concatenation for OpenVINO IR (#2052)

* Add spatial concatenation to deployment demo (#2089)

---------

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Inhyuk Cho <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix RELEASE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants