Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loss dynamics tracking for CustomSingleStageDetector #2115

Merged
merged 5 commits into from
May 15, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented May 8, 2023

Summary

  • Ticket no. 93287
  • Add training loss dynamics exportation feature for CustomSingleStageDetector model.

How to test

I added unit tests about this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests labels May 8, 2023
@vinnamkim vinnamkim changed the title Add CustomSSDHeadTrackingLossDynamics Add CustomSSDTrackingLossDynamics May 8, 2023
@vinnamkim vinnamkim changed the title Add CustomSSDTrackingLossDynamics Support loss dynamics tracking for CustomSingleStageDetector May 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 95.76% and project coverage change: +0.50 🎉

Comparison is base (1b09c03) 79.53% compared to head (58ee987) 80.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2115      +/-   ##
===========================================
+ Coverage    79.53%   80.04%   +0.50%     
===========================================
  Files          461      463       +2     
  Lines        34076    34515     +439     
===========================================
+ Hits         27102    27626     +524     
+ Misses        6974     6889      -85     
Flag Coverage Δ
py310 80.04% <95.76%> (+0.51%) ⬆️
py38 80.02% <95.76%> (+0.50%) ⬆️
py39 80.02% <95.76%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
otx/algorithms/detection/adapters/mmdet/task.py 85.42% <66.66%> (-0.13%) ⬇️
...ithms/detection/adapters/mmdet/models/loss_dyns.py 77.27% <77.27%> (ø)
otx/core/data/noisy_label_detection/base.py 89.28% <90.00%> (-1.20%) ⬇️
...on/adapters/mmdet/models/heads/custom_atss_head.py 91.13% <94.38%> (+65.80%) ⬆️
...ion/adapters/mmdet/models/heads/custom_ssd_head.py 87.41% <95.18%> (+41.14%) ⬆️
...ication/adapters/mmcls/models/classifiers/mixin.py 96.55% <100.00%> (-0.17%) ⬇️
...ithms/detection/adapters/mmdet/datasets/dataset.py 94.36% <100.00%> (+0.12%) ⬆️
...dapters/mmdet/datasets/pipelines/load_pipelines.py 97.87% <100.00%> (+0.04%) ⬆️
...ers/mmdet/models/detectors/custom_atss_detector.py 67.56% <100.00%> (+1.81%) ⬆️
...t/models/detectors/custom_single_stage_detector.py 72.00% <100.00%> (+7.05%) ⬆️
... and 6 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim force-pushed the vinnamki/feature/noisy-label-detection-ssd branch from baf9fae to c6db50a Compare May 12, 2023 07:17
@github-actions github-actions bot removed the API Any changes in OTX API label May 12, 2023
@vinnamkim vinnamkim marked this pull request as ready for review May 12, 2023 07:18
@vinnamkim vinnamkim requested a review from a team as a code owner May 12, 2023 07:18
@vinnamkim vinnamkim requested a review from wonjuleee May 12, 2023 07:22
Signed-off-by: Kim, Vinnam <[email protected]>
@github-actions github-actions bot added CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation labels May 15, 2023
@vinnamkim vinnamkim force-pushed the vinnamki/feature/noisy-label-detection-ssd branch from 2ed8d06 to cbf7ecc Compare May 15, 2023 05:23
@github-actions github-actions bot removed DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation CLI Any changes in OTE CLI labels May 15, 2023
wonjuleee
wonjuleee previously approved these changes May 15, 2023
sungmanc
sungmanc previously approved these changes May 15, 2023
@vinnamkim vinnamkim dismissed stale reviews from sungmanc and wonjuleee via 58ee987 May 15, 2023 06:06
Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim requested a review from sungmanc May 15, 2023 09:02
@vinnamkim vinnamkim requested a review from wonjuleee May 15, 2023 09:02
@goodsong81 goodsong81 added this to the 1.3.0 milestone May 15, 2023
@vinnamkim vinnamkim merged commit afb33b7 into develop May 15, 2023
@vinnamkim vinnamkim deleted the vinnamki/feature/noisy-label-detection-ssd branch May 15, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants