-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async demo in exportable code #2154
Merged
sovrasov
merged 9 commits into
openvinotoolkit:develop
from
GalyaZalesskaya:gz/async_demo
May 17, 2023
Merged
Fix async demo in exportable code #2154
sovrasov
merged 9 commits into
openvinotoolkit:develop
from
GalyaZalesskaya:gz/async_demo
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunwoosh
previously approved these changes
May 16, 2023
jaegukhyun
previously approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any test method for demo codes?
@jaegukhyun Yes, at least in e2e tests:
This test deploys the model, runs the exportable code demo, and saves the output. Then it validates that demo didn't crash and the output was saved. Tests missed this use case because there is no test for async inference, the sync was used by default
|
@GalyaZalesskaya Thanks for reply, do you have any plan to add async test to e2e? |
@jaegukhyun Thank you for this suggestion. I'll add async exportable code demo tests in this PR |
jaegukhyun
previously approved these changes
May 16, 2023
sovrasov
previously approved these changes
May 16, 2023
GalyaZalesskaya
force-pushed
the
gz/async_demo
branch
from
May 16, 2023 15:42
3acc049
to
25a0e91
Compare
jaegukhyun
approved these changes
May 17, 2023
sovrasov
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the crush of demo in exportable code started in async mode. The issue was caused by the unsupported annotation format returned from async pipeline (Detection instance instead of
np.array
instance).np.array
formatRelated issue: CVS-84793
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.