Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async demo in exportable code #2154

Merged
merged 9 commits into from
May 17, 2023

Conversation

GalyaZalesskaya
Copy link
Contributor

Summary

This PR fixes the crush of demo in exportable code started in async mode. The issue was caused by the unsupported annotation format returned from async pipeline (Detection instance instead of np.array instance).

  • Converted prediction results to np.array format
  • Fixed names used for demo outputs if the original input names can't be used

Related issue: CVS-84793

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@GalyaZalesskaya GalyaZalesskaya added API Any changes in OTX API FIX defect fix labels May 15, 2023
@GalyaZalesskaya GalyaZalesskaya requested a review from a team as a code owner May 15, 2023 15:57
@github-actions github-actions bot added the DOC Improvements or additions to documentation label May 15, 2023
eunwoosh
eunwoosh previously approved these changes May 16, 2023
jaegukhyun
jaegukhyun previously approved these changes May 16, 2023
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any test method for demo codes?

@GalyaZalesskaya
Copy link
Contributor Author

@jaegukhyun Yes, at least in e2e tests:

def test_otx_deploy_openvino(self, template, tmp_dir_path):

This test deploys the model, runs the exportable code demo, and saves the output. Then it validates that demo didn't crash and the output was saved.
Tests missed this use case because there is no test for async inference, the sync was used by default

@jaegukhyun
Copy link
Contributor

@GalyaZalesskaya Thanks for reply, do you have any plan to add async test to e2e?

@GalyaZalesskaya
Copy link
Contributor Author

@jaegukhyun Thank you for this suggestion. I'll add async exportable code demo tests in this PR

@GalyaZalesskaya GalyaZalesskaya dismissed stale reviews from jaegukhyun and eunwoosh via 483d507 May 16, 2023 08:03
@github-actions github-actions bot added the TEST Any changes in tests label May 16, 2023
jaegukhyun
jaegukhyun previously approved these changes May 16, 2023
sovrasov
sovrasov previously approved these changes May 16, 2023
@GalyaZalesskaya GalyaZalesskaya dismissed stale reviews from sovrasov and jaegukhyun via 3acc049 May 16, 2023 15:35
@sovrasov sovrasov merged commit e62bc7e into openvinotoolkit:develop May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API DOC Improvements or additions to documentation FIX defect fix TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants