bugfix: auto adapt batch size doesn't work with cls incr case #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ALGO
eunwoosh
changed the title
sungmanc
previously approved these changes
May 25, 2023
jaegukhyun
previously approved these changes
May 25, 2023
eunwoosh
dismissed stale reviews from jaegukhyun and sungmanc
The base branch was changed.
goodsong81
approved these changes
May 26, 2023
jaegukhyun
approved these changes
May 26, 2023
goodsong81
pushed a commit
that referenced
this pull request
May 26, 2023
* auto adapt consider cls incremental case * align with pre-commit * update changelog
goodsong81
added a commit
that referenced
this pull request
Jun 5, 2023
* Fix e2e (#2179) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update noisy label det docs for detection task (#2183) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Add supcon seg for regression (#2177) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update regression test config (#2186) * Fix for anomaly regression test (#2188) * Fix iseg regression (#2190) * Set path to save pseudo masks into workspace (#2185) * Temporary fix override_configs bug (#2187) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Cleaned up skip/xfail TCs on the classification e2e tests (#2196) * Added csv output to export dependencies (#2178) * Fix typo and enlarge the threshold for KPI tests (#2198) * bugfix: auto adapt batch size doesn't work with cls incr case (#2199) * Fix for ssd (#2197) * Turn off persistent worker if num_worker is zero in classification task (#2208) * Update test cases of common_semantic_segmentation_dataset (#2210) * Optimize counting train & inference speed and memory consumption (#2172) * Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174) * Add warning message to tiling parameter (#2193) * Change the way to pad for instance-segmentation * Hotfix: use 0 confidence threshold when computing best threshold based on F1 * Fix possible bw issue in exportable code (#2212) * Fix ellipse load (#2214) * Fix GT vs prediction order mismatch due to different sorting result (#2216) * Return raw anomaly maps as metadata (#2217) * Fix merge error, revert to pymongo w/o version spec --------- Signed-off-by: Songki Choi <[email protected]> Signed-off-by: Kim, Vinnam <[email protected]> Co-authored-by: Jaeguk Hyun <[email protected]> Co-authored-by: Vinnam Kim <[email protected]> Co-authored-by: Sungman Cho <[email protected]> Co-authored-by: Eunwoo Shin <[email protected]> Co-authored-by: Kim, Sungchul <[email protected]> Co-authored-by: Yunchu Lee <[email protected]> Co-authored-by: Jihwan Eom <[email protected]> Co-authored-by: Eugene Liu <[email protected]> Co-authored-by: sungmanc <[email protected]> Co-authored-by: Vladislav Sovrasov <[email protected]> Co-authored-by: Dick Ameln <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's because
ClsIncrSampleruses old dataset versus new dataset ratio, but subset for auto adapt batch size doesn't consider it.This PR adds a code to set old dataset versus new dataset ratio as proper value which can works well with
ClsIncrSampler.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.