Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NNCF & OpenVINO #2656

Merged
merged 29 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2558665
Upgrade OV MAPI and NNCF version
sovrasov Nov 20, 2023
166f6b4
Update demo requirements
sovrasov Nov 20, 2023
61c61fc
Update changelog
sovrasov Nov 20, 2023
75d1775
Update datumaro
sovrasov Nov 20, 2023
d5bec65
Add rust installation
sovrasov Nov 20, 2023
061ad26
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Nov 21, 2023
7c8db8c
Update NNCF configs for IS models
sovrasov Nov 22, 2023
08f7ca2
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Nov 22, 2023
5b91c32
Update more fqs
sovrasov Nov 25, 2023
440b596
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Nov 25, 2023
8ca885c
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Nov 27, 2023
09f59f8
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Nov 28, 2023
8926c51
Exclude nncf from upgrade
sovrasov Nov 28, 2023
f904c0c
Revert "Update NNCF configs for IS models"
sovrasov Nov 28, 2023
005c1da
Revert "Update more fqs"
sovrasov Nov 28, 2023
d23f33d
Revert "Exclude nncf from upgrade"
sovrasov Nov 28, 2023
b784955
Update FQs
sovrasov Nov 29, 2023
4767217
Revert "Revert "Update NNCF configs for IS models""
sovrasov Nov 29, 2023
7b33fd4
Disable explain for NNCF detection task
sovrasov Dec 4, 2023
5b60d3f
Merge remote-tracking branch 'origin/develop' into vs/upd_ov_2023_2_2
sovrasov Dec 4, 2023
00374c3
Update FQs for anomaly
sovrasov Dec 5, 2023
22b0ee0
Update cls FQs
sovrasov Dec 5, 2023
c0c79f9
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Dec 6, 2023
2988fdc
Update datumaro
sovrasov Dec 8, 2023
045840f
Update exportable code requirements
sovrasov Dec 8, 2023
a00c303
Merge remote-tracking branch 'origin/develop' into vs/ov_2023_2
sovrasov Dec 11, 2023
c70c5c5
Merge branch 'develop' into vs/ov_2023_2
sovrasov Dec 12, 2023
cd16f52
Add unit test to cover the changes
sovrasov Dec 15, 2023
0055431
Merge branch 'develop' into vs/ov_2023_2
sovrasov Dec 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pre_merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Installing Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Set up Python
uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -52,6 +54,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Installing Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Install Python
uses: actions/setup-python@v4
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/run_tests_in_tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Installing Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Set up Python
uses: actions/setup-python@v4
with:
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,18 @@ All notable changes to this project will be documented in this file.

- Add zero-shot visual prompting (https://github.com/openvinotoolkit/training_extensions/pull/2616)

### Enhancements

- Upgrade NNCF to 2.7 and OpenVINO to 2023.2 (<https://github.com/openvinotoolkit/training_extensions/pull/2656>)

## \[v1.5.0\]

### New features

- Enable configurable confidence threshold for otx eval and export (<https://github.com/openvinotoolkit/training_extensions/pull/2388>)
- Add YOLOX variants as new object detector models (<https://github.com/openvinotoolkit/training_extensions/pull/2402>)
- Enable FeatureVectorHook to support action tasks (<https://github.com/openvinotoolkit/training_extensions/pull/2408>)
- Add ONNX metadata to detection, instance segmantation, and segmentation models (<https://github.com/openvinotoolkit/training_extensions/pull/2418>)
- Add ONNX metadata to detection, instance segmentation, and segmentation models (<https://github.com/openvinotoolkit/training_extensions/pull/2418>)
- Add a new feature to configure input size (<https://github.com/openvinotoolkit/training_extensions/pull/2420>)
- Introduce the OTXSampler and AdaptiveRepeatDataHook to achieve faster training at the small data regime (<https://github.com/openvinotoolkit/training_extensions/pull/2428>)
- Add a new object detector Lite-DINO (<https://github.com/openvinotoolkit/training_extensions/pull/2457>)
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ natsort==8.1.*
prettytable==3.9.*
protobuf==3.20.*
pyyaml
datumaro~=1.6.0rc0
datumaro @ git+https://github.com/openvinotoolkit/datumaro/@3782380de8788dabd32eb18e872d4d075f934e8e#egg=datumaro
psutil==5.9.*
scipy==1.10.*
bayesian-optimization==1.4.*
Expand Down
8 changes: 4 additions & 4 deletions requirements/openvino.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
# OpenVINO Requirements. #
nncf==2.6.0
nncf==2.7.0
onnx==1.13.0
openvino-model-api==0.1.6
openvino==2023.1.0
openvino-dev==2023.1.0
openvino-model-api==0.1.7
openvino==2023.2.0
openvino-dev==2023.2.0
openvino-telemetry==2023.2.*
2 changes: 2 additions & 0 deletions src/otx/algorithms/detection/adapters/mmdet/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@

dump_features = True
dump_saliency_map = not inference_parameters.is_evaluation if inference_parameters else True
if isinstance(self, NNCFBaseTask):
dump_saliency_map = False

Check warning on line 313 in src/otx/algorithms/detection/adapters/mmdet/task.py

View check run for this annotation

Codecov / codecov/patch

src/otx/algorithms/detection/adapters/mmdet/task.py#L313

Added line #L313 was not covered by tests

self._init_task()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
"algorithm": "quantization",
"initializer": {
"range": {
"type": "percentile",
"params": {
"min_percentile": 0,
"max_percentile": 100
},
sovrasov marked this conversation as resolved.
Show resolved Hide resolved
"num_init_samples": 1000
},
"batchnorm_adaptation": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
"algorithm": "quantization",
"initializer": {
"range": {
"type": "percentile",
"params": {
"min_percentile": 0,
"max_percentile": 100
},
"num_init_samples": 1000
},
"batchnorm_adaptation": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
"algorithm": "quantization",
"initializer": {
"range": {
"type": "percentile",
"params": {
"min_percentile": 0,
"max_percentile": 100
},
"num_init_samples": 1000
},
"batchnorm_adaptation": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
"algorithm": "quantization",
"initializer": {
"range": {
"type": "percentile",
"params": {
"min_percentile": 0,
"max_percentile": 100
},
"num_init_samples": 1000
},
"batchnorm_adaptation": {
Expand Down
6 changes: 3 additions & 3 deletions src/otx/api/usecases/exportable_code/demo/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
openvino==2023.0
openvino-model-api==0.1.6
otx @ git+https://github.com/openvinotoolkit/training_extensions/@0e1200f4cc5343dcac597674fc97a898fc9829c2#egg=otx
openvino==2023.2.0
openvino-model-api==0.1.7
otx @ git+https://github.com/openvinotoolkit/training_extensions/@2988fdc51ef7e4a136a9d4e09602b3844d7bafec#egg=otx
numpy>=1.21.0,<=1.23.5 # np.bool was removed in 1.24.0 which was used in openvino runtime
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ TestToolsHierarchicalClassification:
nncf:
number_of_fakequantizers: 267
ptq:
number_of_fakequantizers: 177
number_of_fakequantizers: 207
TestToolsMultiClassClassification:
nncf:
number_of_fakequantizers: 267
ptq:
number_of_fakequantizers: 177
number_of_fakequantizers: 207
TestToolsMultilabelClassification:
nncf:
number_of_fakequantizers: 269
ptq:
number_of_fakequantizers: 179
number_of_fakequantizers: 209
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ TestToolsHierarchicalClassification:
nncf:
number_of_fakequantizers: 124
ptq:
number_of_fakequantizers: 76
number_of_fakequantizers: 92
TestToolsMultiClassClassification:
nncf:
number_of_fakequantizers: 124
ptq:
number_of_fakequantizers: 76
number_of_fakequantizers: 92
TestToolsMultilabelClassification:
nncf:
number_of_fakequantizers: 126
ptq:
number_of_fakequantizers: 78
number_of_fakequantizers: 94
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
TestToolsOTXInstanceSegmentation:
nncf:
number_of_fakequantizers: 204
ptq:
number_of_fakequantizers: 137
pot:
number_of_fakequantizers: 137
ptq:
number_of_fakequantizers: 160
TestToolsTilingInstanceSegmentation:
nncf:
number_of_fakequantizers: 204
ptq:
number_of_fakequantizers: 137
pot:
number_of_fakequantizers: 137
ptq:
number_of_fakequantizers: 160
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
TestToolsOTXInstanceSegmentation:
nncf:
number_of_fakequantizers: 97
ptq:
number_of_fakequantizers: 99
pot:
number_of_fakequantizers: 99
ptq:
number_of_fakequantizers: 99
TestToolsTilingInstanceSegmentation:
nncf:
number_of_fakequantizers: 97
ptq:
number_of_fakequantizers: 99
pot:
number_of_fakequantizers: 99
ptq:
number_of_fakequantizers: 99
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ TestToolsOTXSegmentation:
nncf:
number_of_fakequantizers: 1138
ptq:
number_of_fakequantizers: 942
number_of_fakequantizers: 1026