Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torchvision in MRCNN on CUDA #3347

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Apr 17, 2024

Summary

This could mitigate QAT instability on some datasets
Dataset: geti test data from the ticket
Model: ResNet50 MRCNN

Backend iter time total train time f-score
mmcv 0.362 0:03:06 0.4021
torchvision 0.365 0:03:09 0.405

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 17, 2024
@sovrasov sovrasov changed the title Always use torchvision in MRCNN Use torchvision in MRCNN on CUDA Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (76b89ea) to head (dee36bb).

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.0    #3347      +/-   ##
==================================================
- Coverage           80.76%   80.73%   -0.03%     
==================================================
  Files                 536      536              
  Lines               40476    40477       +1     
==================================================
- Hits                32689    32681       -8     
- Misses               7787     7796       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuneuny-emily
Copy link
Contributor

@sovrasov - Will it affect the speed of nncf optimization a lot? Should it only be applied to MaskRCNN-ResNet50 which was the offending thing? or all models?

@sovrasov
Copy link
Contributor Author

@sovrasov - Will it affect the speed of nncf optimization a lot? Should it only be applied to MaskRCNN-ResNet50 which was the offending thing? or all models?

This PR is for testing purposes, I'll update the implementation later to restrict the scope of the changes. Also, I'm planning to benchmark performance and accuracy with this patch today

@github-actions github-actions bot added the TEST Any changes in tests label Apr 18, 2024
@sovrasov
Copy link
Contributor Author

sovrasov commented Apr 18, 2024

@chuneuny-emily please see the benchmark results mmcv vs torchvision in the PR description. torchvision is slightly slower, but I think this is acceptable.

@sovrasov sovrasov marked this pull request as ready for review April 18, 2024 13:01
@sovrasov sovrasov requested a review from a team as a code owner April 18, 2024 13:01
@chuneuny-emily chuneuny-emily merged commit 5fbe606 into releases/1.6.0 Apr 18, 2024
16 checks passed
@chuneuny-emily chuneuny-emily deleted the vs/fix_nncf_mrcnn_failure branch April 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants