Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model_api action classification model wrapper class #3610

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Jun 12, 2024

Summary

Currently, OTX uses own model_api model wrapper for action classification task.
It's implemented at model_api 0.2.1, so make OTX use it and remove unnecessary code.

Integration test result

image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh changed the title [do not merge] Use model_api action classification model wrapper class [Do not merge] Use model_api action classification model wrapper class Jun 12, 2024
@sovrasov sovrasov added this to the 2.2.0 milestone Jun 25, 2024
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD labels Jun 27, 2024
@eunwoosh eunwoosh changed the base branch from develop to releases/2.1.0 June 27, 2024 01:21
@eunwoosh eunwoosh changed the title [Do not merge] Use model_api action classification model wrapper class Use model_api action classification model wrapper class Jun 27, 2024
@eunwoosh eunwoosh marked this pull request as ready for review June 27, 2024 07:16
sovrasov
sovrasov previously approved these changes Jun 27, 2024
@sovrasov
Copy link
Contributor

@eunwoosh this PR is not required for 2.1, so please retarget back to develop

@eunwoosh eunwoosh changed the base branch from releases/2.1.0 to develop June 27, 2024 07:54
@eunwoosh eunwoosh requested a review from sovrasov June 27, 2024 07:55
@eunwoosh
Copy link
Contributor Author

@eunwoosh this PR is not required for 2.1, so please retarget back to develop

Ok I changed target branch to develop

sovrasov
sovrasov previously approved these changes Jun 27, 2024
harimkang
harimkang previously approved these changes Jun 28, 2024
@eunwoosh eunwoosh enabled auto-merge (squash) July 2, 2024 10:17
@sovrasov
Copy link
Contributor

sovrasov commented Jul 2, 2024

@eunwoosh please apply changes from this PR: #3703

@eunwoosh eunwoosh dismissed stale reviews from harimkang and sovrasov via ea51024 July 2, 2024 10:48
@github-actions github-actions bot added the TEST Any changes in tests label Jul 2, 2024
@eunwoosh eunwoosh merged commit 3a44e46 into openvinotoolkit:develop Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants