-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use model_api action classification model wrapper class #3610
Merged
eunwoosh
merged 5 commits into
openvinotoolkit:develop
from
eunwoosh:align_model_api_action
Jul 2, 2024
Merged
Use model_api action classification model wrapper class #3610
eunwoosh
merged 5 commits into
openvinotoolkit:develop
from
eunwoosh:align_model_api_action
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunwoosh
changed the title
[do not merge] Use model_api action classification model wrapper class
[Do not merge] Use model_api action classification model wrapper class
Jun 12, 2024
github-actions
bot
added
DEPENDENCY
Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
BUILD
labels
Jun 27, 2024
eunwoosh
force-pushed
the
align_model_api_action
branch
from
June 27, 2024 01:21
370d499
to
f96ff6c
Compare
eunwoosh
changed the title
[Do not merge] Use model_api action classification model wrapper class
Use model_api action classification model wrapper class
Jun 27, 2024
eunwoosh
requested review from
samet-akcay,
harimkang,
vinnamkim,
eugene123tw,
kprokofi,
chuneuny-emily,
sovrasov,
sungchul2,
GalyaZalesskaya,
negvet,
goodsong81,
yunchu and
wonjuleee
as code owners
June 27, 2024 07:16
sovrasov
previously approved these changes
Jun 27, 2024
@eunwoosh this PR is not required for 2.1, so please retarget back to develop |
eunwoosh
force-pushed
the
align_model_api_action
branch
from
June 27, 2024 07:54
f96ff6c
to
f981616
Compare
Ok I changed target branch to develop |
sovrasov
previously approved these changes
Jun 27, 2024
harimkang
previously approved these changes
Jun 28, 2024
sovrasov
approved these changes
Jul 2, 2024
kprokofi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BUILD
DEPENDENCY
Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
TEST
Any changes in tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, OTX uses own model_api model wrapper for action classification task.
It's implemented at model_api 0.2.1, so make OTX use it and remove unnecessary code.
Integration test result
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.