Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move value to device before logging for metric #3649

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Jun 20, 2024

Summary

This is for #3635
and also to deal with Lightning-AI/pytorch-lightning#18803
There is a bug that when updating a value on cpu to metric instance from torchmetric, error is raised during distributed training.
To fix it, I added code to move value to current device explicitly.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh merged commit 779a0b0 into openvinotoolkit:develop Jun 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants