Move value to device before logging for metric #3649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is for #3635
and also to deal with Lightning-AI/pytorch-lightning#18803
There is a bug that when updating a value on cpu to metric instance from torchmetric, error is raised during distributed training.
To fix it, I added code to move value to current device explicitly.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.