-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantic segmentation transforms to use OTX's instead of torchvision #3724
Merged
sungchul2
merged 35 commits into
openvinotoolkit:develop
from
sungchul2:update-sseg-tv-to-otx
Jul 15, 2024
Merged
Update semantic segmentation transforms to use OTX's instead of torchvision #3724
sungchul2
merged 35 commits into
openvinotoolkit:develop
from
sungchul2:update-sseg-tv-to-otx
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ea6ee8.
…r compatibility with other task (iseg)
sungchul2
requested review from
samet-akcay,
harimkang,
vinnamkim,
eugene123tw,
kprokofi,
chuneuny-emily,
sovrasov,
GalyaZalesskaya,
negvet,
goodsong81,
yunchu,
wonjuleee and
eunwoosh
as code owners
July 12, 2024 06:56
eunwoosh
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work:) I left some comments. Please take a look.
Co-authored-by: Eunwoo Shin <[email protected]>
eunwoosh
approved these changes
Jul 14, 2024
harimkang
approved these changes
Jul 15, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes:
before
performance is fromafter
in Recipe refinement (det, iseg, r-det, sseg, vpm, zsl) #3712before
: 746d07e |after
: 2e32819**NOTE
When using
RandomResize
+RandomCrop
+Pad
(mmseg pipeline) instead ofRandomResizedCrop
(current, torchvision pipeline), it seems that sometimes very small GT region was extracted like below figure and it significantly affected training performance, especially segnext_t (test/Dice : 0.46 and export/Dice 0.45). Due to this issue, useRandomResizedCrop
instead.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.