Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change run-on target to aws ci for e2e #3745

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Jul 16, 2024

Summary

  • change run-on target to aws-ci for e2e test
  • remove on-push event from pre-merge
  • prevent run integration test for draft PR

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the BUILD label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (30bcc40) to head (1707cfa).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3745   +/-   ##
========================================
  Coverage    79.96%   79.96%           
========================================
  Files          252      252           
  Lines        25629    25629           
========================================
  Hits         20493    20493           
  Misses        5136     5136           
Flag Coverage Δ
py310 79.94% <ø> (+0.08%) ⬆️
py311 79.91% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu marked this pull request as ready for review July 16, 2024 07:05
@yunchu yunchu enabled auto-merge (squash) July 16, 2024 08:13
Copy link
Contributor

@kprokofi kprokofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to ask you a question regarding new testing pipeline:

As I understand now we will have a merging queue and e2e tests will be executed once a day? Will be tests executed only for the last PR in the queue or for all of them? What will happened if e2e will fail, will the PR automatically reopened?

@yunchu
Copy link
Contributor Author

yunchu commented Jul 17, 2024

I want to ask you a question regarding new testing pipeline:

As I understand now we will have a merging queue and e2e tests will be executed once a day? Will be tests executed only for the last PR in the queue or for all of them? What will happened if e2e will fail, will the PR automatically reopened?

the only changes on the e2e tests are the run-on target from the self-hosed CI runners (now suspended) to AWS CI runners. it's about enabling back the e2e from the disabled by suspension of self-hosted runners.

and for the merge queue, it will be used for the merge process of the PR. it will enqueue the PR to merge queue maximum 5 or 5 minutes and all enqueued PR will be merged together to run the pre-merge testing (unit test + integration test). if all checks are passed, it will be merged but will not perform the test again on the target (merged) branch (develop) and if there are any failures/errors, github will find the PR that caused errors and then exclude it from the candidate list to be merged and that will be remained as open.
you can find more details about merge queue from here

@yunchu yunchu merged commit 51e12ed into openvinotoolkit:develop Jul 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants