-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '--test-only' flag in perf test #3746
Add '--test-only' flag in perf test #3746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a little bit misleading not executing otx export
when specifying --resume-from export
? It sounds like rather --resume-after
to me.
(Not saying that it should be renamed to "after", thouth)
you're right, but it's hard to find proper name. So far, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, why should we add second option with resume_from. Why only one resume is not enough to continue training? Let's imagine we have some workspace with already completed train stage for small datasets. Can we just write: pytest test_*.py --work-dir /path/to/it --eval-upto optimize --resume. After that I would expect that export -> optimize on small datasets will be executed
It looks complicated for me with two resumes
It's for saving more time when running huge number of models. Current perf test resume feature just skips training part. So, if user uses |
I think @kprokofi's comment makes sense. Isn't it some kind of test-only feature that you really need? |
I understand what you said. I'll revert "--resume" to "--resume-from" and change "--resume-from" to "--test-only". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR adds
--test-only
flags to perf test. When it's set, perf test copies all necessary files from resume directory and executes onlyotx test
with specified operation. If files can't be found from resume directory, necessary operations will be executed automatically.Additionally, bug that error is raised when setting device to
cpu
is fixed.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.