Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump torch and lightning to 2.4.0 versions #3843

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

kprokofi
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (8e6f831) to head (e93642b).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3843      +/-   ##
===========================================
+ Coverage    81.01%   81.11%   +0.09%     
===========================================
  Files          277      276       -1     
  Lines        27252    27147     -105     
===========================================
- Hits         22079    22021      -58     
+ Misses        5173     5126      -47     
Flag Coverage Δ
py310 80.69% <ø> (-0.30%) ⬇️
py311 80.89% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuneuny-emily chuneuny-emily added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@kprokofi kprokofi added this pull request to the merge queue Aug 19, 2024
@kprokofi
Copy link
Contributor Author

@harimkang , we have multilabel-classification tests failed randomly. I noticed that during my SSeg PR and this PR also fails randomly. Could you take a look?

@kprokofi kprokofi removed this pull request from the merge queue due to a manual request Aug 19, 2024
@harimkang
Copy link
Contributor

@harimkang , we have multilabel-classification tests failed randomly. I noticed that during my SSeg PR and this PR also fails randomly. Could you take a look?

I'll try to reproduce it and take a look.

@harimkang
Copy link
Contributor

@kprokofi I think it's safe to target 2.3 for this, what do you think?

@kprokofi kprokofi added this to the 2.3.0 milestone Aug 20, 2024
@kprokofi kprokofi added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 20, 2024
@kprokofi kprokofi added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 20, 2024
@harimkang harimkang added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 21, 2024
@harimkang
Copy link
Contributor

@harimkang , we have multilabel-classification tests failed randomly. I noticed that during my SSeg PR and this PR also fails randomly. Could you take a look?

#3869 -> I expect this PR to resolve the issue. merged that PR first and then merge this PR.

@harimkang harimkang added this pull request to the merge queue Aug 21, 2024
Merged via the queue into develop with commit d5c8140 Aug 21, 2024
20 checks passed
@harimkang harimkang deleted the kp/update_torch branch August 21, 2024 12:15
sooahleex pushed a commit to sooahleex/training_extensions that referenced this pull request Aug 26, 2024
update torch and lightning, check

Co-authored-by: Harim Kang <[email protected]>
sooahleex pushed a commit to sooahleex/training_extensions that referenced this pull request Aug 26, 2024
update torch and lightning, check

Co-authored-by: Harim Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants