Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MaskRCNN rotated detection #3858

Merged

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Aug 16, 2024

Summary

  • Align MaskRCNN instance segmentation recipes with MaskRCNN rotated detection recipes.
  • Add tile-based recipes for rotated object detection.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@kprokofi
Copy link
Contributor

@chuneuny-emily , I think we may merge it before CF and target OTX2.2, since there are no much changes, mostly configs.

@kprokofi kprokofi added this to the 2.2.0 milestone Aug 19, 2024
@sovrasov sovrasov added this pull request to the merge queue Aug 19, 2024
@yunchu yunchu removed this pull request from the merge queue due to the queue being cleared Aug 20, 2024
@harimkang harimkang merged commit 4f696f1 into openvinotoolkit:develop Aug 20, 2024
19 of 22 checks passed
@sungchul2
Copy link
Contributor

@eugene123tw @kprokofi Just a question, if rotated detection models use instance segmentation modules, isn't this task a sub task of instance segmentation like multi class classification of classification?

@eugene123tw
Copy link
Contributor Author

@eugene123tw @kprokofi Just a question, if rotated detection models use instance segmentation modules, isn't this task a sub task of instance segmentation like multi class classification of classification?

Currently, rotated detection can be a subset of inst-seg, as both tasks share the same model interface at the moment (not sure if we are going to add detection based rotated algo), differing in only prediction functions. I guess this relationship makes it somewhat similar to how multi-class classification relates to general classification tasks.

@eugene123tw eugene123tw deleted the eugene/refactor-rotated-det branch September 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants