Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Object Detection 3D #3979

Merged
merged 41 commits into from
Oct 2, 2024
Merged

Add Object Detection 3D #3979

merged 41 commits into from
Oct 2, 2024

Conversation

kprokofi
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@kprokofi
Copy link
Contributor Author

kprokofi commented Sep 25, 2024 •
edited
Loading

Please, disregard KITTI Dataset for review. It will be removed. The work on Datumaro adaptation in progress

sungchul2
sungchul2 reviewed Sep 26, 2024
View reviewed changes
src/otx/algo/common/losses/focal_loss.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/__init__.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/backbones/backbone.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/detectors/monodetr.py Show resolved Hide resolved
src/otx/algo/object_detection_3d/detectors/monodetr.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/heads/depth_predictor.py Show resolved Hide resolved
src/otx/algo/object_detection_3d/losses/balancer.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/losses/ddn_loss.py Show resolved Hide resolved
src/otx/algo/object_detection_3d/losses/monodetr_loss.py Outdated Show resolved Hide resolved
src/otx/algo/object_detection_3d/utils/__init__.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD labels Sep 26, 2024
@github-actions github-actions bot added the TEST Any changes in tests label Sep 26, 2024
eunwoosh
eunwoosh reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your huge work in short time :) I left some comments, but I know it's hard to deal with all comments now. So, please close some comments and handle it in next PR if you have no time.

tests/perf/test_object_detection_3d.py Show resolved Hide resolved
src/otx/recipe/object_detection_3d/monodetr3d.yaml Show resolved Hide resolved
src/otx/recipe/_base_/data/object_detection_3d.yaml Show resolved Hide resolved
src/otx/algo/object_detection_3d/monodetr3d.py Show resolved Hide resolved
src/otx/algo/object_detection_3d/monodetr3d.py Show resolved Hide resolved
src/otx/core/data/utils/utils.py Show resolved Hide resolved
src/otx/core/exporter/base.py Show resolved Hide resolved
src/otx/core/metrics/kitti_3d_eval/eval.py Show resolved Hide resolved
src/otx/core/data/dataset/object_detection_3d.py Show resolved Hide resolved
src/otx/algo/detection/heads/rtdetr_decoder.py Show resolved Hide resolved
eunwoosh
eunwoosh previously approved these changes Sep 30, 2024
View reviewed changes
harimkang
harimkang previously approved these changes Sep 30, 2024
View reviewed changes
@harimkang harimkang dismissed stale reviews from eunwoosh and themself via 648e3e4 September 30, 2024 06:19
@harimkang harimkang enabled auto-merge (squash) September 30, 2024 08:27
@sovrasov
Copy link
Contributor

@harimkang
image
please have a look. I think this is caused by your changes in this PR

@sovrasov
Copy link
Contributor

sovrasov commented Sep 30, 2024 •
edited
Loading

Unfortunately, the task is runnable only on a piece of kitty we have in tests/assets. Datumaro fails to import the real kitty. Overall, the PR is ok to merge.
Related PR: openvinotoolkit/datumaro#1621

@harimkang
Copy link
Contributor

@harimkang

image

please have a look. I think this is caused by your changes in this PR

sorry but i didnt understand. I don't think that has anything to do with my changes.

@harimkang harimkang merged commit 7773abb into develop Oct 2, 2024
19 of 22 checks passed
@harimkang harimkang deleted the kp/add_3d_det_task branch October 2, 2024 04:23
@sovrasov
Copy link
Contributor

sovrasov commented Oct 2, 2024

@harimkang sorry, it was Yunchu, who changed the python version for the UTs

@kprokofi kprokofi mentioned this pull request Oct 16, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungchul2 sungchul2 sungchul2 left review comments

@harimkang harimkang harimkang approved these changes

@sovrasov sovrasov sovrasov approved these changes

@eunwoosh eunwoosh eunwoosh left review comments

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@eugene123tw eugene123tw Awaiting requested review from eugene123tw eugene123tw is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya GalyaZalesskaya is a code owner

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81 goodsong81 is a code owner

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner

@wonjuleee wonjuleee Awaiting requested review from wonjuleee wonjuleee is a code owner

Assignees
No one assigned
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@kprokofi @sovrasov @harimkang @eunwoosh @sungchul2 @wonjuleee @yunchu