0.12.1 #2926
0.12.1 #2926
Conversation
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
|
|
@jamshale -- could you please look at the integration test error? Presumably intermittent, but not one I recognize. |
There was a problem hiding this comment.
Testing with example scenarios in minimal example repo all look good: Indicio-tech/acapy-minimal-example#88
Tests against Credo (run locally) also passed using the 0.12.1rc1 image.
LGTM! Assuming the integration test failure is indeed just an intermittent issue.
|
The integration test got a duplicate record error setting up endorser roles. I've never seen this before. I'd like to have a look at this closer and figure out if it's a blocking issue or not. |
|
I'm going to look into that error from the integration tests and make a ticket. I'm sure it's intermittent and already existed, but still, it shouldn't be able to happen. Doesn't affect the release. |
|
FYI on the failed integration test. Seems like, somehow the test created a race condition, by duplicating a /set-endorser-role request, with these lines. creating a duplicate record. I tried to recreate the problem but haven't been able to. Because I've never seen this error before and seems very unlikely to happen on this endpoint in practice, I'd say we don't have to worry about it. |
Signed-off-by: Stephen Curran [email protected]