Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 0.12.x #3121

Merged
merged 15 commits into from
Jul 24, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jul 23, 2024

This patches via cherry pick some commits we want in 0.12.x. You can see the commits below. The PRs are as follows.

The integration tests pipeline doesn't work for patches to branches other than main. We'd need a ticket if we want to support this. For this release I integration tested locally with the @gha tag and all features passed.

jamshale and others added 13 commits July 23, 2024 19:45
This corrects an issue where did:peer:4 connection records were failing
to be resolved on inbound message, resulting in the multiuse invitation
that created the connection being resolved instead.

Fixes openwallet-foundation#3111.

Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
To make signing mechanisms for JSON-LD pluggable.

Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
This change relaxes some overly strict validation that was preventing
presenting proof using LDP-VC from Credo 0.5.X based agents.

Signed-off-by: Daniel Bluhm <[email protected]>
@jamshale jamshale marked this pull request as ready for review July 23, 2024 20:00
@dbluhm
Copy link
Contributor

dbluhm commented Jul 24, 2024

@jamshale I'll run this branch through a few tests and report back

@dbluhm
Copy link
Contributor

dbluhm commented Jul 24, 2024

Any way we can trigger an AATH run on this branch?

@swcurran
Copy link
Contributor

Yes — but only running locally, which I can do if you need. Edit the ACA-Py Main Requirements file and change the referenced branch to the one to test.

@swcurran
Copy link
Contributor

And then — ./manage runset acapy should do it.

@dbluhm
Copy link
Contributor

dbluhm commented Jul 24, 2024

I haven't run against the AATH yet but I ran the examples in AME and the interop tests in acapy-afj-interop and all tests came back looking good.

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that @jamshale beat me to running AATH against this branch so I'm going to go ahead and approve. This is looking really solid; all tests attempted so far are green.

@swcurran swcurran merged commit 4e20667 into openwallet-foundation:0.12.x Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants