fix: disallow floating promises (#704)

Signed-off-by: Timo Glastra <[email protected]>
openwallet-foundation · Apr 13, 2022 · 549647d · 549647d
1 parent 2b6441a
commit 549647d
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 10 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -31,6 +31,7 @@ module.exports = {
     'no-console': 'error',
     '@typescript-eslint/ban-ts-comment': 'warn',
     '@typescript-eslint/consistent-type-imports': 'error',
+    '@typescript-eslint/no-floating-promises': 'error',
     'import/no-cycle': 'error',
     'import/newline-after-import': ['error', { count: 1 }],
     'import/order': [

diff --git a/packages/core/src/agent/Agent.ts b/packages/core/src/agent/Agent.ts
@@ -175,11 +175,11 @@ export class Agent {
     }
 
     for (const transport of this.inboundTransports) {
-      transport.start(this)
+      await transport.start(this)
     }
 
     for (const transport of this.outboundTransports) {
-      transport.start(this)
+      await transport.start(this)
     }
 
     // Connect to mediator through provided invitation if provided in config
@@ -201,10 +201,10 @@ export class Agent {
 
     // Stop transports
     for (const transport of this.outboundTransports) {
-      transport.stop()
+      await transport.stop()
     }
     for (const transport of this.inboundTransports) {
-      transport.stop()
+      await transport.stop()
     }
 
     // close wallet if still initialized

diff --git a/packages/core/src/modules/credentials/services/CredentialService.ts b/packages/core/src/modules/credentials/services/CredentialService.ts
@@ -149,7 +149,7 @@ export class CredentialService {
     // Update record
     credentialRecord.proposalMessage = proposalMessage
     credentialRecord.credentialAttributes = proposalMessage.credentialProposal?.attributes
-    this.updateState(credentialRecord, CredentialState.ProposalSent)
+    await this.updateState(credentialRecord, CredentialState.ProposalSent)
 
     return { message: proposalMessage, credentialRecord }
   }

diff --git a/packages/core/src/modules/proofs/services/ProofService.ts b/packages/core/src/modules/proofs/services/ProofService.ts
@@ -166,7 +166,7 @@ export class ProofService {
 
     // Update record
     proofRecord.proposalMessage = proposalMessage
-    this.updateState(proofRecord, ProofState.ProposalSent)
+    await this.updateState(proofRecord, ProofState.ProposalSent)
 
     return { message: proposalMessage, proofRecord }
   }

diff --git a/packages/core/src/modules/routing/RecipientModule.ts b/packages/core/src/modules/routing/RecipientModule.ts
@@ -157,7 +157,7 @@ export class RecipientModule {
         this.logger.warn(
           `Websocket connection to mediator with connectionId '${mediator.connectionId}' is closed, attempting to reconnect...`
         )
-        this.openMediationWebSocket(mediator)
+        await this.openMediationWebSocket(mediator)
       })
 
     await this.openMediationWebSocket(mediator)

diff --git a/packages/core/src/transport/HttpOutboundTransport.ts b/packages/core/src/transport/HttpOutboundTransport.ts
@@ -84,7 +84,7 @@ export class HttpOutboundTransport implements OutboundTransport {
             )
             return
           }
-          this.agent.receiveMessage(encryptedMessage)
+          await this.agent.receiveMessage(encryptedMessage)
         } catch (error) {
           this.logger.debug('Unable to parse response message')
         }

diff --git a/packages/core/src/transport/WsOutboundTransport.ts b/packages/core/src/transport/WsOutboundTransport.ts
@@ -109,7 +109,7 @@ export class WsOutboundTransport implements OutboundTransport {
       )
     }
     this.logger.debug('Payload received from mediator:', payload)
-    this.agent.receiveMessage(payload)
+    void this.agent.receiveMessage(payload)
   }
 
   private listenOnWebSocketMessages(socket: WebSocket) {

diff --git a/samples/mediator.ts b/samples/mediator.ts
@@ -94,4 +94,4 @@ const run = async () => {
   })
 }
 
-run()
+void run()