-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume errors are of type unknown instead of type error #594
Comments
Need to resolve this issue first: openwallet-foundation#594 Signed-off-by: Timo Glastra <[email protected]>
Looks like you've got this fixed in https://github.com/animo/aries-framework-javascript/tree/build/demo-tsconfig |
Hi @brianorwhatever, Sadly this hasn't been addressed yet. That PR locks the version of TS to an older version so we don't get the error, but we still need to update all catch statements to assume the errors are of type unknown. Do you have a specific need for this change? |
I was having troubles getting the demos running but I did the same and locked the ts version and it worked after that so I'm not in a hurry anymore. thanks! |
We want to use unknown in catch statements. Before typescript 4.4
any
was the default but this is now switched tounknown
. Once we have migrated all catch statements to assume error is of typeunknown
we can upgrade to the new typescript versionWe could also use
useUnknownInCatchVariables: false
in the roottsconfig.build.json
for nowThe text was updated successfully, but these errors were encountered: