Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proofs): delete associated didcomm messages #1021

Conversation

TimoGlastra
Copy link
Contributor

Resolves #860

@TimoGlastra TimoGlastra requested a review from a team as a code owner September 8, 2022 20:07
@TimoGlastra TimoGlastra linked an issue Sep 8, 2022 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #1021 (95bdaa8) into 0.3.0-pre (f38ac05) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           0.3.0-pre    #1021      +/-   ##
=============================================
- Coverage      87.87%   87.82%   -0.05%     
=============================================
  Files            615      615              
  Lines          14764    14772       +8     
  Branches        2498     2500       +2     
=============================================
  Hits           12974    12974              
- Misses          1693     1700       +7     
- Partials          97       98       +1     
Impacted Files Coverage Δ
packages/core/src/modules/proofs/ProofService.ts 70.96% <0.00%> (-20.70%) ⬇️
packages/core/src/modules/proofs/ProofsApi.ts 85.05% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@genaris genaris added this to the v0.3.0 milestone Sep 9, 2022
@TimoGlastra TimoGlastra merged commit dba46c3 into openwallet-foundation:0.3.0-pre Sep 9, 2022
genaris pushed a commit to 2060-io/aries-framework-javascript that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a proof record should delete the associated didcomm messages
3 participants