Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue credentials v2 (W3C/JSON-LD) #1092

Merged

Conversation

NB-MikeRichardson
Copy link
Contributor

No description provided.

Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
@NB-MikeRichardson NB-MikeRichardson requested a review from a team as a code owner November 9, 2022 09:27
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1092 (1fa0dfd) into main (15cfd91) will increase coverage by 0.06%.
The diff coverage is 84.32%.

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   88.33%   88.40%   +0.06%     
==========================================
  Files         701      706       +5     
  Lines       16111    16342     +231     
  Branches     2597     2640      +43     
==========================================
+ Hits        14232    14447     +215     
- Misses       1872     1888      +16     
  Partials        7        7              
Impacted Files Coverage Δ
...ges/core/src/modules/credentials/CredentialsApi.ts 86.91% <ø> (ø)
...les/credentials/formats/CredentialFormatService.ts 100.00% <ø> (ø)
...ntials/formats/indy/IndyCredentialFormatService.ts 87.95% <0.00%> (+0.52%) ⬆️
...s/protocol/v2/handlers/V2IssueCredentialHandler.ts 96.00% <ø> (ø)
...s/protocol/v2/handlers/V2OfferCredentialHandler.ts 67.74% <ø> (ø)
...protocol/v2/handlers/V2RequestCredentialHandler.ts 96.42% <0.00%> (ø)
...ckages/core/src/modules/dids/domain/DidDocument.ts 96.47% <ø> (ø)
...e/src/modules/proofs/formats/ProofFormatService.ts 100.00% <ø> (ø)
...credentials/formats/jsonld/JsonLdOptionsRFC0593.ts 57.14% <57.14%> (ø)
...ls/formats/jsonld/JsonLdCredentialFormatService.ts 85.88% <85.88%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

NB-MikeRichardson and others added 3 commits November 9, 2022 12:49
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
fix(routing): async message pickup on init (openwallet-foundation#1093)
@TimoGlastra
Copy link
Contributor

@NB-MikeRichardson seems like tests are still failing. Can't merge before those are resolved...

@NB-MikeRichardson
Copy link
Contributor Author

The failing test only seems to fail in 18.x. I have run this test on my local machine for all versions of node, and it runs fine except in 18.x. It is related to the Bbs signatures it seems.

How does one go about fixing this test?

@genaris
Copy link
Contributor

genaris commented Nov 10, 2022

@NB-MikeRichardson seems like tests are still failing. Can't merge before those are resolved...

It's the problem with BBS libraries. How can we avoid running them in node 18?

@NB-MikeRichardson
Copy link
Contributor Author

NB-MikeRichardson commented Nov 10, 2022

@NB-MikeRichardson seems like tests are still failing. Can't merge before those are resolved...

It's the problem with BBS libraries. How can we avoid running them in node 18?

Strangely enough I can get it running (sometimes) on my local machine (even with node 18). It seems to be inconsistent, do we know what the problem is with BBS libraries in 18.x?

@TimoGlastra
Copy link
Contributor

@NB-MikeRichardson for all tests that include BBS code you should use describeSkipNode17And18 instead of describe at the top of the test file. This will skip the tests in Node 17 and 18

@TimoGlastra TimoGlastra changed the title feat: Issue Credentials V2 (W3C/JSON-LD) with Commits Squashed feat: issue credentials v2 (W3C/JSON-LD) Nov 11, 2022
@TimoGlastra TimoGlastra merged commit 574e6a6 into openwallet-foundation:main Nov 11, 2022
@NB-MikeRichardson NB-MikeRichardson deleted the feat/icv2-new branch November 14, 2022 08:40
Artemkaaas pushed a commit to sicpa-dlab/aries-framework-javascript that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants