Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename plugin to module #1201

Merged

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both README were based on Push Notifications from aries-framework-javascript-ext, so it would be appropriate to update the naming there as well. However I'm not sure how to call it there because that package includes two different modules (the one for APN and the one for FCM) 🤯

@codecov-commenter
Copy link

Codecov Report

Merging #1201 (2ae5a5d) into main (fd006f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         708      708           
  Lines       16614    16614           
  Branches     2809     2809           
=======================================
  Hits        14770    14770           
  Misses       1736     1736           
  Partials      108      108           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra
Copy link
Contributor Author

so it would be appropriate to update the naming there as well.

Will do

I'm not sure how to call it there because that package includes two different modules

I think we can just mention that it's a package with two modules

@TimoGlastra TimoGlastra merged commit da7abde into openwallet-foundation:main Jan 10, 2023
@TimoGlastra TimoGlastra deleted the chore/pulgin-to-module branch January 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants