fix: stopped recvRequest from receiving outbound messages #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadeking98
changed the title
wadeking98
changed the title
wadeking98
changed the title
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
fix-recv-request
branch
from
3621a0d
to
300c077
Compare
genaris
approved these changes
Mar 2, 2024
TimoGlastra
reviewed
Mar 3, 2024
| @@ -109,7 +110,7 @@ export class DrpcApi { | |||
| removeListener: () => void | |||
There was a problem hiding this comment.
Not related to this PR, but I'm not a big fan on reicvRequest over receiveRequest, that feels more consistent with other methods in Credo (we almost never abbreviate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the drpc method
recvRequestwould receive messages that had just been send by the agent. This is a quick fix to ensure the method on receives incoming requests from other agents