feat(proofs): present proof as nested protocol #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
TimoGlastra
approved these changes
Aug 8, 2022
|
Nice addition @genaris! I think it would be great to look at a generic way to do this (if possible, maybe we should have a base protocol implementation with handlers/records etc..), but for now this will do fine. |
|
Can you update the branch? |
|
Thanks @TimoGlastra! And I agree that it would be nice to find an easier way to start any protocol as a child of another one (even if some of them, such as Basic Messages and Action Menu, are not originally meant to work as sub-protocols). |
TimoGlastra
changed the title
|
Reminder: this PR needs to be integrated with the PP v2 work that has changed basically everything about the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As exemplified in Aries RFC 0008, there are certain situations where proofs must be exchanged as part of an inner flow, such as a credential issuance.
This PR attempts to support launching a Present Proof V1 protocol as a sub-protocol from another one, without impacting current Agent behaviour and API (apart from adding some fields and methods). It does not, however, add support for all threading concepts (such as
sender_orderandreceiver_order), as it might introduce breaking changes and also needs to be more carefully designed.Signed-off-by: Ariel Gentile [email protected]