Resolve Contains_key Closes #305 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update PULL_REQUEST_TEMPLATE.md Added a new line referencing prompting the user to add or update examples * Update PULL_REQUEST_TEMPLATE.md updated wording
jdidion
requested changes
Jan 30, 2024
SPEC.md
Outdated
| ### ✨ `contains_key` | ||
|
|
||
| ``` | ||
| Map[P, Y], P), Boolean contains_key(Map[P?, Y], P?) |
There was a problem hiding this comment.
Looks like a bad merge here. Check the original diff: https://github.com/openwdl/wdl/compare/cf597dc07eb88d2fe727bbeb10473569f7b412d8..1af834fa053360f9c84dea734abcfc6bf202bb0c
jdidion
requested changes
Jan 31, 2024
SPEC.md
Outdated
| ### ✨ `contains_key` | ||
|
|
||
| ``` | ||
| Map[P, Y], Boolean contains_key(Map[P?, Y], P?) |
There was a problem hiding this comment.
Still something weird going on here. See for e.g. min and max for other functions with multiple variants.
Should be:
* Boolean contains_key(Map[P, Y], P)
* Boolean contains_key(Object, String)
* Boolean contains_key(Map[String, Y]|Struct|Object, Array[String])
jdidion
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist