Integrated topology history feature from django-netjsongraph #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
reviewed
Aug 18, 2017
There was a problem hiding this comment.
Good!
As said in openwisp/django-netjsongraph#49 (comment) the requirements.txt will have to point to django-netjsongraph>=0.4.0
nemesifier
reviewed
Aug 26, 2017
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('openwisp_users', '0002_auto_20170719_0052'), |
There was a problem hiding this comment.
this migration doesn't exists in the openwisp-users repo, what is it?
There was a problem hiding this comment.
Oh. I observed this earlier too. Upon running the make migrations command, this is being made. Then I manually changed this to 0001_initial to make the build run.
There was a problem hiding this comment.
I think we'll need to edit it to prevent the builds from failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2. Can be merged after openwisp/django-netjsongraph#49 is merged and released.