Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stealth extension #1037

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Stealth extension #1037

wants to merge 18 commits into from

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Apr 26, 2023

This PR is a rebased version of #1036 to support the merged extension.

Iirc we discussed upstreaming this with @bkrumnow already and the GPLv3 should allow us to merge this back with any issues. Using MPL licensed code is GPLv3 is also no issue.

closes #1031
closes #448
closes #1081

@vringar vringar mentioned this pull request Apr 26, 2023
@bkrumnow
Copy link

bkrumnow commented May 15, 2023

@vringar Let me know, if there is anything needed. I am happy to help.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f72e7ca) 45.73% compared to head (0cfc12f) 45.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
+ Coverage   45.73%   45.74%   +0.01%     
==========================================
  Files          35       35              
  Lines        3481     3482       +1     
==========================================
+ Hits         1592     1593       +1     
  Misses       1889     1889              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vringar
Copy link
Contributor Author

vringar commented Feb 7, 2024

@bkrumnow as this is finally building, iirc you had you had a detection website for the current version of the JSInstrument.
Could you share that again, so I can turn it into tests that verify that the stealth extension can't be detected.

My next step would be to replace the current JS Instrument with your implementation as it seems strictly better (are there any limitations that I missed?), so this will get merged once the stealth implementation passes the JSInstrument tests and there are tests that verify that stealth still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants