-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stealth extension #1037
base: master
Are you sure you want to change the base?
Stealth extension #1037
Conversation
@vringar Let me know, if there is anything needed. I am happy to help. |
c9ec210
to
39d3175
Compare
39d3175
to
bdf7960
Compare
2b4d05c
to
d3469b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
+ Coverage 45.73% 45.74% +0.01%
==========================================
Files 35 35
Lines 3481 3482 +1
==========================================
+ Hits 1592 1593 +1
Misses 1889 1889 ☔ View full report in Codecov by Sentry. |
@bkrumnow as this is finally building, iirc you had you had a detection website for the current version of the JSInstrument. My next step would be to replace the current JS Instrument with your implementation as it seems strictly better (are there any limitations that I missed?), so this will get merged once the stealth implementation passes the JSInstrument tests and there are tests that verify that stealth still works. |
This PR is a rebased version of #1036 to support the merged extension.
Iirc we discussed upstreaming this with @bkrumnow already and the GPLv3 should allow us to merge this back with any issues. Using MPL licensed code is GPLv3 is also no issue.
closes #1031
closes #448
closes #1081