Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webdriver HTML attribute from documentElement and navigator #105

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Remove webdriver HTML attribute from documentElement and navigator #105

merged 1 commit into from
Nov 17, 2016

Conversation

gunesacar
Copy link
Contributor

@gunesacar gunesacar commented Nov 16, 2016 •
edited
Loading

Fixes #91.

The fix assumes that OpenWPM's content.js runs after Selenium code linked below.

Manually tested on https://output.jsbin.com/webawamabu.

The console logs should read:

- Successfully started all instrumentation
- navigator.webdriver:  undefined
- webdriver in navigator:  false
- documentElement attribute webdriver:  null

@gunesacar gunesacar mentioned this pull request Nov 16, 2016
Closed
@englehardt englehardt merged commit 4b40448 into openwpm:master Nov 17, 2016
@englehardt
Copy link
Collaborator

Looks great, thanks Gunes!

This was referenced Nov 17, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block webdriver html attribute from getting set
2 participants
@gunesacar @englehardt