-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config documentation into docstrings #920
Conversation
Hello @vringar could you review this PR that I'm doing right or not? please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Ayushsunny,
sorry for taking a while to get back to you.
I left a comment showing how the docstring should be formatted.
As you can see all the tests are currently failing because the way you inserted the docstrings is invalid in python. |
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
- Coverage 50.91% 50.73% -0.18%
==========================================
Files 34 34
Lines 3390 3390
==========================================
- Hits 1726 1720 -6
- Misses 1664 1670 +6
Continue to review full report at Codecov.
|
Hello Sir, I have amend the changes. |
This looks really good, thank you! |
@vringar Done |
Can you see now @vringar ? |
This looks very good. Thank you! |
Move config documentation into docstrings
issue code - #916