Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: don't build in parallel #17274

Closed
wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Contributor

@mweinelt mweinelt commented Dec 5, 2021

Parallel builds cause spurious build failures with high core counts.

Closes: #8238
Signed-off-by: Martin Weinelt [email protected]

Maintainer: @pprindeville
Compile tested: (put here arch, model, OpenWrt version) multiple (18.06, 19.07, 21.02)
Run tested: (put here arch, model, OpenWrt version, tests done) multiple (18.06, 19.07, 21.02)

I have been using this patchset for >1y.

Description: Fixes #8238

Copy link
Member

@pprindeville pprindeville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to change the PKG_RELEASE as well.

@mweinelt
Copy link
Contributor Author

Bumped release to 6.

Parallel builds cause spurious build failures with high core counts.

Closes: openwrt#8238
Signed-off-by: Martin Weinelt <[email protected]>
@mweinelt
Copy link
Contributor Author

Rebased.

@mweinelt
Copy link
Contributor Author

Not sure how the test failures are related.

@pprindeville
Copy link
Member

Parallel builds cause spurious build failures with high core counts.

@mweinelt By the way, what constitutes "high core counts"? Because I have an 6-core VM that I routinely build on, and I've never seen this...

@mweinelt
Copy link
Contributor Author

mweinelt commented Jan 6, 2022

My build host has 32C/64T.

@blocktrron
Copy link
Member

@pprindeville As I'm also facing this from time to time - any objections against merging?

@pprindeville
Copy link
Member

I'd rather reduce the parallelism that set it to one.

What about capping the number of jobs?

@karlp
Copy link
Contributor

karlp commented Jan 31, 2022

Has anyone tried following this up with perl upstream? it seems like something they'd want to be fixing too?

@pprindeville
Copy link
Member

Has anyone tried following this up with perl upstream? it seems like something they'd want to be fixing too?

Indeed.

@lemoer
Copy link
Contributor

lemoer commented May 5, 2022

What is the state here? Is there anything going to happen?

@pprindeville
Copy link
Member

What is the state here? Is there anything going to happen?

Wanting to know what's been communicated upstream.

Also, please investigate the build failures.

@Rondom
Copy link
Contributor

Rondom commented Mar 7, 2024

I have investigated the failure and came up with the following: #23602

@mweinelt
Copy link
Contributor Author

Superseded by #23602.

@mweinelt mweinelt closed this Jul 28, 2024
@mweinelt mweinelt deleted the perl-no-parallel-builds branch July 28, 2024 21:58
@pprindeville
Copy link
Member

Sorry for the delay. Been busy with satellite stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perl: spurious build failures on openwrt-18.06 branch
6 participants